This repository has been archived by the owner on May 21, 2024. It is now read-only.
docker-app: Fix bad parameters file logic #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker-app was changed between the original testing in 0.6 and the current 0.8 to not accept the short-hand argument for the parameters file. This change uses the long for which is easier to read and "just works". Signed-off-by: Andy Doan <andy@foundries.io>
Codecov Report
@@ Coverage Diff @@
## master #1468 +/- ##
=========================================
- Coverage 80.61% 80.51% -0.1%
=========================================
Files 184 184
Lines 11081 11081
=========================================
- Hits 8933 8922 -11
- Misses 2148 2159 +11
Continue to review full report at Codecov.
|
pattivacek
approved these changes
Dec 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-app was changed between the original testing in 0.6 and the
current 0.8 to not accept the short-hand argument for the parameters
file. This change uses the long for which is easier to read and
"just works".
Signed-off-by: Andy Doan andy@foundries.io