This repository has been archived by the owner on May 21, 2024. It is now read-only.
OTA-4174: IP-Secondary: match Director's and Imagerepo's targets #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1513 +/- ##
==========================================
- Coverage 80.85% 80.77% -0.08%
==========================================
Files 184 184
Lines 11182 11186 +4
==========================================
- Hits 9041 9036 -5
- Misses 2141 2150 +9
Continue to review full report at Codecov.
|
|
Unfortunately, my first attempt at testing this failed failed with these errors on the Secondary when I sent it an update: Also seeing this repeatedly on the Primary: |
pattivacek
force-pushed
the
fix/secondary-verification
branch
from
47f3ad6 to
324f988
Compare
Co-Authored-By: Mykhaylo Sul <myk.sul@gmail.com> Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
- Each target listed in Director's target file should have corresponding match in ImageRepo's one - Test for the use-case if IP Secondary Director's target file and ImageRepo's one have different number of targets - Separate the ostree specific tests from non-ostree one in the IP Secondary Verification test suite Signed-off-by: Mike Sul <ext-mykhaylo.sul@here.com> Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Also include the serial to make it somewhat more useful. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
pattivacek
force-pushed
the
fix/secondary-verification
branch
from
324f988 to
02423b8
Compare
|
Doesn't work and seems unnecessary after all. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of fc6eafd from #1500 to address a possible bug. Still requires some further investigation and review, but I think we might need this sooner than the rest of that PR.