This repository has been archived by the owner on May 21, 2024. It is now read-only.
Remove clang-tidy's modernize-pass-by-value #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Group checks on several lines Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
This check is too radical and has difficult implications when designing interfaces. It also has caused at least one use-after-move bug. Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
lbonn
requested review from
pattivacek,
eu-siemann,
mike-sul,
xcheng-here and
kbushgit
pattivacek
approved these changes
Jan 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lint has caused problems in the past and is going in the way of some refactors.