Merge pull request #1525 from advancedtelematic/fix/secondary-root-version-bump #1525
Conversation
pattivacek
force-pushed
the
fix/secondary-root-version-bump
branch
from
a7026d0 to
93a748b
Compare
| /* | ||
| * Bump the version of the Director Root metadata. | ||
| */ | ||
| TEST(uptane_generator, refreshDirectorRoot) { |
There was a problem hiding this comment.
These tests looks really similar.
Would be cool to make most of their body common, with TEST_P or one test.
Might be impractical or just as ugly though, no big deal.
There was a problem hiding this comment.
Yeah, these are pretty repetitive. I haven't gotten into parameterized testing much yet. Would be cool to do, just haven't had the time yet.
There was a problem hiding this comment.
Ok, in this case it's probably not worth holding up this PR then.
Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
All that really means right now is bumping the version. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
pattivacek
force-pushed
the
fix/secondary-root-version-bump
branch
from
93a748b to
d62ecf4
Compare
lbonn
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1525 +/- ##
==========================================
- Coverage 81.91% 81.86% -0.05%
==========================================
Files 186 186
Lines 11361 11397 +36
==========================================
+ Hits 9306 9330 +24
- Misses 2055 2067 +12
Continue to review full report at Codecov.
|
aktualizr_secondary: Accept initial Root metadata with version > 1.