Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

ref: moving all configs definition into a single file #1707

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Conversation

kbushgit
Copy link
Contributor

@kbushgit kbushgit commented Jul 7, 2020

Signed-off-by: Kostiantyn Bushko kostiantyn.bushko@yahoo.com

@pattivacek
Copy link
Collaborator

Is this just the config changes from #1688 pulled out into a separate PR? Or which one should we focus on and review/merge first?

#include "logging/logging_config.h"
#include "package_manager/packagemanagerconfig.h"
#include "storage/storage_config.h"
#include "libaktualizr/config.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is slightly unfortunate that we have to include a bunch more stuff in aktualizr-secondary that we won't actually use, but for now that seems like a small issue that we can address at another time.

@pattivacek
Copy link
Collaborator

CI only failed because of an issue that Eugene has fixed. Can you rebase?

Kostiantyn Bushko added 2 commits July 7, 2020 12:49
Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>
Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2020

Codecov Report

Merging #1707 into master will decrease coverage by 0.77%.
The diff coverage is 74.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
- Coverage   73.24%   72.47%   -0.78%     
==========================================
  Files         195      188       -7     
  Lines       14055    14226     +171     
==========================================
+ Hits        10295    10310      +15     
- Misses       3760     3916     +156     
Impacted Files Coverage Δ
src/aktualizr_get/main.cc 0.00% <ø> (ø)
src/aktualizr_info/aktualizr_info_config.h 66.66% <ø> (-33.34%) ⬇️
src/aktualizr_lite/main.cc 70.19% <ø> (ø)
src/aktualizr_primary/main.cc 80.00% <ø> (ø)
...c/aktualizr_secondary/aktualizr_secondary_config.h 66.66% <ø> (-33.34%) ⬇️
src/cert_provider/main.cc 62.46% <ø> (ø)
...baktualizr-c/test/api-test-utils/api-test-utils.cc 85.71% <ø> (ø)
src/libaktualizr/bootloader/bootloader.h 100.00% <ø> (ø)
src/libaktualizr/bootloader/bootloader_config.cc 90.00% <ø> (ø)
src/libaktualizr/crypto/keymanager.h 100.00% <ø> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce3f819...85ff81d. Read the comment docs.

@kbushgit
Copy link
Contributor Author

kbushgit commented Jul 7, 2020

Is this just the config changes from #1688 pulled out into a separate PR? Or which one should we focus on and review/merge first?

this is just refactoring of configs, lets focus on this PR first

Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pattivacek pattivacek merged commit 689b6b0 into master Jul 7, 2020
@pattivacek pattivacek deleted the ref/config branch July 7, 2020 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants