Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

New StructGuard variant to support non-void return types. #1714

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

pattivacek
Copy link
Collaborator

gcc9 explicitly complains about the previous solution of casting the function parameter.

gcc9 explicitly complains about the previous solution of casting the
function parameter.

Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
@pattivacek pattivacek requested review from eu-siemann and kbushgit July 8, 2020 08:52
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #1714 into master will increase coverage by 3.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1714      +/-   ##
==========================================
+ Coverage   74.47%   77.56%   +3.09%     
==========================================
  Files         185      185              
  Lines       13699    13144     -555     
==========================================
- Hits        10202    10195       -7     
+ Misses       3497     2949     -548     
Impacted Files Coverage Δ
src/libaktualizr/utilities/utils.h 93.33% <ø> (ø)
src/libaktualizr/utilities/utils.cc 87.80% <100.00%> (+19.26%) ⬆️
src/libaktualizr/storage/sqlstorage_base.h 60.00% <0.00%> (-40.00%) ⬇️
src/libaktualizr/storage/sqlstorage_base.cc 76.19% <0.00%> (-4.09%) ⬇️
src/libaktualizr/package_manager/ostreemanager.cc 79.77% <0.00%> (-0.74%) ⬇️
src/libaktualizr-posix/ipuptanesecondary.cc 81.31% <0.00%> (+0.98%) ⬆️
src/libaktualizr/storage/sqlstorage.cc 57.34% <0.00%> (+1.14%) ⬆️
src/libaktualizr-posix/asn1/asn1_message.h 64.51% <0.00%> (+5.69%) ⬆️
...c/virtual_secondary/partialverificationsecondary.h 30.76% <0.00%> (+5.76%) ⬆️
src/virtual_secondary/managedsecondary.h 100.00% <0.00%> (+7.69%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d5bad...43e6c39. Read the comment docs.

I'm not sure how this worked before...

Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
@pattivacek pattivacek merged commit 85a25c9 into master Jul 8, 2020
@pattivacek pattivacek deleted the fix/gcc9-function-cast branch July 8, 2020 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants