Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Document exceptions thrown through the API. #1737

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

pattivacek
Copy link
Collaborator

This list is not exhaustive, but should give a high-level view of what to expect.

Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
This list is not exhaustive, but should give a high-level view of what
to expect.

Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2020

Codecov Report

Merging #1737 into master will decrease coverage by 0.27%.
The diff coverage is 4.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1737      +/-   ##
==========================================
- Coverage   73.64%   73.37%   -0.28%     
==========================================
  Files         180      180              
  Lines       13908    13949      +41     
==========================================
- Hits        10243    10235       -8     
- Misses       3665     3714      +49     
Impacted Files Coverage Δ
include/libaktualizr/campaign.h 40.00% <ø> (-4.45%) ⬇️
include/libaktualizr/types.h 91.73% <0.00%> (+28.66%) ⬆️
src/libaktualizr/crypto/keymanager.cc 58.02% <0.00%> (ø)
src/libaktualizr/crypto/p11engine.cc 74.65% <0.00%> (ø)
src/libaktualizr/primary/sotauptaneclient.cc 74.07% <0.00%> (-18.78%) ⬇️
src/libaktualizr/storage/sql_utils.h 83.11% <0.00%> (ø)
src/libaktualizr/utilities/utils.cc 58.06% <0.00%> (+1.69%) ⬆️
include/libaktualizr/aktualizr.h 50.00% <50.00%> (-50.00%) ⬇️
src/libaktualizr/utilities/utils.h 47.36% <0.00%> (-42.64%) ⬇️
src/libaktualizr/storage/sqlstorage_base.h 60.00% <0.00%> (-40.00%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b37861...c2c54d5. Read the comment docs.

Copy link
Contributor

@xaviergully xaviergully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbushgit kbushgit self-requested a review August 7, 2020 09:33
@pattivacek pattivacek merged commit b7eeb16 into master Aug 7, 2020
@pattivacek pattivacek deleted the feat/OTA-5072/api-exceptions branch August 7, 2020 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants