This repository has been archived by the owner on May 21, 2024. It is now read-only.
packagemanage: Fix output of pacman config #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is perhaps counterintuitive, and I'm surprised no one noticed until now. :) I think this might deserve a small unit test to prevent future breakage. |
doanac
force-pushed
the
config-dump-fix
branch
from
7f8e76a to
52df53c
Compare
Great idea. I force pushed a unit test for this. |
When the config is dumped out for the docker-app manager, the custom config key/vals are printed val=key. eg: "/tmp/sota/docker-apps" = docker_apps_root This fixes the issue. Signed-off-by: Andy Doan <andy@foundries.io>
doanac
force-pushed
the
config-dump-fix
branch
from
52df53c to
d9abc9f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the config is dumped out for the docker-app manager, the custom
config key/vals are printed val=key. eg:
"/tmp/sota/docker-apps" = docker_apps_root
This fixes the issue.
Signed-off-by: Andy Doan andy@foundries.io