org.xwiki.commons:xwiki-commons-xml's HTML sanitizer allows form elements in restricted
Critical severity
GitHub Reviewed
Published
Jun 29, 2023
in
xwiki/xwiki-commons
•
Updated Nov 5, 2023
Package
Affected versions
>= 14.6-rc-1, < 14.10.6
>= 15.0-rc-1, < 15.2-rc-1
Patched versions
14.10.6
15.2-rc-1
Description
Published by the National Vulnerability Database
Jun 29, 2023
Published to the GitHub Advisory Database
Jun 30, 2023
Reviewed
Jun 30, 2023
Last updated
Nov 5, 2023
Impact
The HTML sanitizer that is included in XWiki since version 14.6RC1 allowed form and input HTML tags. In the context of XWiki, this allows an attacker without script right to either create forms that can be used for phishing attacks or also in the context of a sheet, the attacker could add an input like
{{html}}<input type="hidden" name="content" value="{{groovy}}println("Hello from Groovy!")" />{{/html}}
that would allow remote code execution when it is submitted by an admin (the sheet is rendered as part of the edit form). The attacker would need to ensure that the edit form looks plausible, though, which can be non-trivial as without script right the attacker cannot display the regular content of the document.Patches
This has been patched in XWiki 14.10.6 and 15.2RC1 by removing the central form-related tags from the list of allowed tags.
Workarounds
An admin can manually disallow the tags by adding
form, input, select, textarea, button
to the configuration optionxml.htmlElementSanitizer.forbidTags
in thexwiki.properties
configuration file.References
References