Summary
A git authentication issue allows a local user’s GitHub token to be sent to remote servers other than github.com.
Details
Most git-dependent functionality in wolfictl relies on its own git package, which contains centralized logic for implementing interactions with git repositories. Some of this functionality requires authentication in order to access private repositories. There’s a central function GetGitAuth:
https://github.com/wolfi-dev/wolfictl/blob/6d99909f7b1aa23f732d84dad054b02a61f530e6/pkg/git/git.go#L22
This looks for a GitHub token in the environment variable GITHUB_TOKEN and returns it as an HTTP basic auth object to be used with the github.com/go-git/go-git/v5 library.
Most callers (direct or indirect) of GetGitAuth use the token to authenticate to github.com only; however, in some cases callers were passing this authentication without checking that the remote git repository was hosted on github.com.
Issue 1
One of these callers processed git URLs from Melange package configurations, cloning the package’s upstream repository in order to determine which project dependencies have been upgraded since the prior update.
https://github.com/wolfi-dev/wolfictl/blob/4dd6c95abb4bc0f9306350a8601057bd7a92bded/pkg/update/deps/cleanup.go#L49
This issue affects the command wolfictl check update, and the set of remote git hosts is a function of the Melange package configuration files residing in the local directory specified in the command.
Issue 2
Another caller processes a git URL received as a command line argument and clones the repository to look for new available versions of the given project.
https://github.com/wolfi-dev/wolfictl/blob/488b53823350caa706de3f01ec0eded9350c7da7/pkg/update/update.go#L143
This issue affects the command wolfictl update.
This behavior has existed in one form or another since wolfi-dev/wolfictl@0d06e15 - committed January 25, 2023.
PoC
GITHUB_TOKEN=test wolfictl update http://git.example.com/
Examining traffic sent to the remote server will show that the HTTP Authorization header contains test in base64 encoded format.
Impact
This impacts anyone who ran the wolfictl check update commands with a Melange configuration that included a git-checkout directive step that referenced a git repository not hosted on github.com.
This also impacts anyone who ran wolfictl update <url> with a remote URL outside of github.com.
Additionally, these subcommands must have run with the GITHUB_TOKEN environment variable set to a valid GitHub token.
References
luhring Reporter
Summary
A git authentication issue allows a local user’s GitHub token to be sent to remote servers other than
github.com.Details
Most git-dependent functionality in wolfictl relies on its own
gitpackage, which contains centralized logic for implementing interactions with git repositories. Some of this functionality requires authentication in order to access private repositories. There’s a central functionGetGitAuth:https://github.com/wolfi-dev/wolfictl/blob/6d99909f7b1aa23f732d84dad054b02a61f530e6/pkg/git/git.go#L22
This looks for a GitHub token in the environment variable
GITHUB_TOKENand returns it as an HTTP basic auth object to be used with thegithub.com/go-git/go-git/v5library.Most callers (direct or indirect) of
GetGitAuthuse the token to authenticate to github.com only; however, in some cases callers were passing this authentication without checking that the remote git repository was hosted on github.com.Issue 1
One of these callers processed git URLs from Melange package configurations, cloning the package’s upstream repository in order to determine which project dependencies have been upgraded since the prior update.
https://github.com/wolfi-dev/wolfictl/blob/4dd6c95abb4bc0f9306350a8601057bd7a92bded/pkg/update/deps/cleanup.go#L49
This issue affects the command
wolfictl check update, and the set of remote git hosts is a function of the Melange package configuration files residing in the local directory specified in the command.Issue 2
Another caller processes a git URL received as a command line argument and clones the repository to look for new available versions of the given project.
https://github.com/wolfi-dev/wolfictl/blob/488b53823350caa706de3f01ec0eded9350c7da7/pkg/update/update.go#L143
This issue affects the command
wolfictl update.This behavior has existed in one form or another since wolfi-dev/wolfictl@0d06e15 - committed January 25, 2023.
PoC
Examining traffic sent to the remote server will show that the HTTP
Authorizationheader containstestin base64 encoded format.Impact
This impacts anyone who ran the
wolfictl check updatecommands with a Melange configuration that included agit-checkoutdirective step that referenced a git repository not hosted on github.com.This also impacts anyone who ran
wolfictl update <url>with a remote URL outside of github.com.Additionally, these subcommands must have run with the
GITHUB_TOKENenvironment variable set to a valid GitHub token.References