Skip to content

Holder can generate proof of ownership for credentials it does not control in vp-toolkit

High severity GitHub Reviewed Published Mar 6, 2020 to the GitHub Advisory Database • Updated Jan 9, 2023

Package

npm vp-toolkit (npm)

Affected versions

< 0.2.2

Patched versions

0.2.2

Description

Impact

The verifyVerifiablePresentation() method check the cryptographic integrity of the Verifiable Presentation, but it does not check if the credentialSubject.id DID matches the signer of the VP proof.

The verifier is impacted by this vulnerability.

Patches

Patch will be available in version 0.2.2.

Workarounds

  • Compute the address out of the verifiablePresentation.proof.n.verificationMethod using getAddressFromPubKey() from crypt-util@0.1.5 and match it with the credentialSubject.id address from the credential.

References

Github issue

For more information

If you have any questions or comments about this advisory:

References

Reviewed Feb 28, 2020
Published to the GitHub Advisory Database Mar 6, 2020
Last updated Jan 9, 2023

Severity

High

Weaknesses

No CWEs

CVE ID

No known CVE

GHSA ID

GHSA-ff5x-w9wg-h275

Source code

No known source code
Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.