Unsound usages of `std::slice::from_raw_parts`
Low severity
GitHub Reviewed
Published
Dec 5, 2024
to the GitHub Advisory Database
•
Updated Dec 5, 2024
Description
Published to the GitHub Advisory Database
Dec 5, 2024
Reviewed
Dec 5, 2024
Last updated
Dec 5, 2024
The library breaks the safety assumptions when using unsafe API
std::slice::from_raw_parts
. First, when using the API in iterator implementation (TempFdArrayIterator.next
), generic type could be any type, which would create and pass a misaligned pointer to the unsafe API. Second, when validating the address, the code passed the typec_void
, which could also be any type, leading to potential uninitialized memory exposure.Two unsound usages here highlight the necessity for developers to perform type checks before doing type conversion with unsafe API.
The panic caused by the misalignment causes several downstream applications (e.g.,
greptimedb
) to crash when usingpprof::report::ReportBuilder::build
.This was patched in 0.14.0.
The developer also suggested moving to pprof2.
References