Skip to content

OpenZeppelin Contracts TransparentUpgradeableProxy clashing selector calls may not be delegated

Moderate severity GitHub Reviewed Published Apr 13, 2023 in OpenZeppelin/openzeppelin-contracts • Updated Nov 23, 2023

Package

npm @openzeppelin/contracts (npm)

Affected versions

>= 3.2.0, < 4.8.3

Patched versions

4.8.3
npm @openzeppelin/contracts-upgradeable (npm)
>= 3.2.0, < 4.8.3
4.8.3

Description

Impact

A function in the implementation contract may be inaccessible if its selector clashes with one of the proxy's own selectors. Specifically, if the clashing function has a different signature with incompatible ABI encoding, the proxy could revert while attempting to decode the arguments from calldata.

The probability of an accidental clash is negligible, but one could be caused deliberately.

Patches

The issue has been fixed in v4.8.3.

Workarounds

If a function appears to be inaccessible for this reason, it may be possible to craft the calldata such that ABI decoding does not fail at the proxy and the function is properly proxied through.

References

OpenZeppelin/openzeppelin-contracts#4154

References

@frangio frangio published to OpenZeppelin/openzeppelin-contracts Apr 13, 2023
Published to the GitHub Advisory Database Apr 17, 2023
Reviewed Apr 17, 2023
Published by the National Vulnerability Database Apr 17, 2023
Last updated Nov 23, 2023

Severity

Moderate

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
None
Availability
Low

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L

EPSS score

0.091%
(40th percentile)

Weaknesses

CVE ID

CVE-2023-30541

GHSA ID

GHSA-mx2q-35m2-x2rh

Source code

Credits

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.