Summary
hyper-bump-it reads a file glob pattern from the configuration file. That is combined with the project root directory to construct a full glob pattern that is used to find files that should be edited. These matched files should be contained within the project root directory, but that is not checked. This could result in changes being written to files outside of the project.
The default behaviour of hyper-bump-it is to display the planned changes and prompt the user for confirmation before editing any files. However, the configuration file provides a field that can be used cause files to be edited without displaying the prompt.
Details
The vulnerability is present in
https://github.com/plannigan/hyper-bump-it/blob/49c726201bbdc02c052302e03fd907d2170e1f47/hyper_bump_it/_hyper_bump_it/files.py#L35
That code joins the project root directory with a string read from the configuration file without checking if the final path is located outside the project root directory.
The following configuration file contents would cause hyper-bump-it to replace every instance of "hello" in every file adjacent to the project root directory with "world". The line setting show_confirm_prompt to false is not required, but will result in the user file edits to occur without the user having a chance to reject the changes (The fact that changes happened would still be displayed).
[hyper-bump-it]
current_version = "1.2.3"
show_confirm_prompt=false
[[hyper-bump-it.files]]
file_glob = "../*"
search_format_pattern = "hello"
replace_format_pattern = "world"
Patches
A fix that been released as part of v0.5.1. The changes can be view as part of PR #307.
Workarounds
Users that are unable to update from vulnerable versions, executing hyper-bump-it with the --interactive command line argument will ensure that all planned changes are displayed and prompt the user for confirmation before editing any files, even if the configuration file contains show_confirm_prompt=true.
References
plannigan Remediation developer
Summary
hyper-bump-itreads a file glob pattern from the configuration file. That is combined with the project root directory to construct a full glob pattern that is used to find files that should be edited. These matched files should be contained within the project root directory, but that is not checked. This could result in changes being written to files outside of the project.The default behaviour of
hyper-bump-itis to display the planned changes and prompt the user for confirmation before editing any files. However, the configuration file provides a field that can be used cause files to be edited without displaying the prompt.Details
The vulnerability is present in
https://github.com/plannigan/hyper-bump-it/blob/49c726201bbdc02c052302e03fd907d2170e1f47/hyper_bump_it/_hyper_bump_it/files.py#L35
That code joins the project root directory with a string read from the configuration file without checking if the final path is located outside the project root directory.
The following configuration file contents would cause
hyper-bump-itto replace every instance of "hello" in every file adjacent to the project root directory with "world". The line settingshow_confirm_prompttofalseis not required, but will result in the user file edits to occur without the user having a chance to reject the changes (The fact that changes happened would still be displayed).Patches
A fix that been released as part of v0.5.1. The changes can be view as part of PR #307.
Workarounds
Users that are unable to update from vulnerable versions, executing
hyper-bump-itwith the--interactivecommand line argument will ensure that all planned changes are displayed and prompt the user for confirmation before editing any files, even if the configuration file containsshow_confirm_prompt=true.References