Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a date issue about one millisecond before midnight #54

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

krisanselmo
Copy link

Description

This PR fix a formatting date issue when typically we manipulate a date that is 1 millisecond before midnight.
The internal usage of .toFixed(7) round the date value to the next day.

Step to reproduce:

const workbook = new Workbook();
const worksheet = workbook.addWorksheet();
worksheet.cell(1, 1).date(new Date('2017-06-01T23:59:59.999Z'));

Result

image

@jrohland
Copy link

Thanks for the PR and updated test. I will review and get a new version up soon with the dependency updates that are pending as well.

@jrohland jrohland merged commit 42bc000 into advisr-io:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants