Improved image and URL metadata handling #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- URLs no longer need to be alive, just valid - Use Laravel's HTTP library, not file_get_contents and streams - Added a bunch of tests - Replaced URL-image-upload mimetype test with response test
It's likely already a dependency of most Laravel application
roelofr
force-pushed
the
improve-url-previews
branch
from
124ef34 to
1418caa
Compare
|
This issue caused a regression when attaching links that have image metadata. the meta.image.url field was just replaced with meta.imageUrl, but this was not reflected in the config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file_get_contentsand streamsmimetypetest with test on HTTP response