Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split groups of save history items that have different status results #1257

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

faush01
Copy link
Contributor

@faush01 faush01 commented Jul 16, 2024

Simple change to split groups of save history items when the status for items in a group changes.

I noticed that the status (icon) was only showing for the first item in a group, if there were say 150 saves and the last 30 failed then it would still show success.

Example of the changes:

image

@nichwall
Copy link
Contributor

Tested and working on Android 14, Pixel 6a.

Test 1 procedure:

  • Started streaming book (let it buffer a bit, got a few sync events)
  • Turned off server (lost connection but did not affect app connectivity)
  • New save icon with red icon was created and counted

Test 2 procedure:

  • Downloaded book
  • Started playing, waited for a sync event
  • Turned on airplane mode on phone
  • Waited for next save event, new event was created as expected
  • Paused, turned off airplane mode, synced with server

@faush01
Copy link
Contributor Author

faush01 commented Jul 31, 2024

Do you need anything else from me on this?

Copy link

@ISO-B ISO-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected with Oneplus One, Android 11. Tested with same procedures as @nichwall

@advplyr
Copy link
Owner

advplyr commented Aug 26, 2024

Thanks!

@advplyr advplyr merged commit b30bd49 into advplyr:master Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants