Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Audiobookshelf restarts when I try to download episodes #1650

Closed
holazit opened this issue Apr 5, 2023 · 7 comments
Closed

[Bug]: Audiobookshelf restarts when I try to download episodes #1650

holazit opened this issue Apr 5, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@holazit
Copy link

holazit commented Apr 5, 2023

Describe the issue

Hi,

I have an issue with two feeds:

  • When I search "PointerPodcast" on Audiobookshelf I can add the feed correctly but when I try to download the latest episodes the container restarts.

2023-04-05 12:42:40 ERROR Invalid inputs to parseAndCheckForUpdates
2023-04-05 12:45:56 ERROR [xmlToJSON] Error Error: Attribute without value Line: 18 Column: 376 Char: >
2023-04-05 12:45:56 ERROR [podcastUtils] Invalid XML or RSS feed
2023-04-05 12:46:41 ERROR [podcastUtils] Invalid XML or RSS feed
2023-04-05 12:50:21 ERROR Invalid inputs to parseAndCheckForUpdates
2023-04-05 12:50:47 INFO === Starting Server ===
2023-04-05 12:50:47 INFO [Server] Init v2.2.18

Is there a problem with that feed or Audiobookshelf have a bug that causes the restart when I open that feed?

  • When I search "Il disinformatico" podcast on Audiobookshelf and I click the result I get the error: "Failed to get podcast feed".

2023-04-05 23:34:19 ERROR [podcastUtils] getPodcastFeed Error AxiosError: Request failed with status code 403

Steps to reproduce the issue

  1. Search "PointerPodcast"

  2. Add the podcast to the library

  3. Open the podcast -> Edit -> Episodes -> Check and download new episodes.

  4. Search "Il disinformatico"

  5. Click on the result.

Audiobookshelf version

2.2.18

How are you running audiobookshelf?

Docker
@holazit holazit added the bug Something isn't working label Apr 5, 2023
advplyr added a commit that referenced this issue Apr 5, 2023
@advplyr
Fix:Podcast RSS feed parse when element has attributes #1650
4d110eb
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Apr 5, 2023
@advplyr
Copy link
Owner

advplyr commented Apr 5, 2023 •
edited
Loading

This had to do with the title having a type attribute in the rss feed. I've never seen that before.

<title type="html">PointerPodcast</title>

https://pointerpodcast.it/index.xml

@advplyr
Copy link
Owner

advplyr commented Apr 16, 2023

Fixed in v2.2.19

@advplyr advplyr closed this as completed Apr 16, 2023
@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label Apr 16, 2023
@holazit
Copy link
Author

holazit commented Apr 17, 2023

Hi, I have the same issue even with v2.2.19: Audiobookshelf restarts when I try to download episodes from that rss feed.

@advplyr
Copy link
Owner

advplyr commented Apr 17, 2023

I'm testing with that podcast and not having an issue. Are you sure you have updated to 2.2.19? Can you be more specific in the issue again?

@holazit
Copy link
Author

holazit commented Apr 17, 2023 •
edited
Loading

Yes, I have updated to 2.2.19. Steps to reproduce the issue:
Search "PointerPodcast"
Add the podcast to the library
Open the podcast -> Edit -> Episodes -> Check and download new episodes.
Audiobookshelf restarts same as the previous version.

2023-04-17 22:34:46 DEBUG [iTunes] Searching for podcast with term "pointerpodcast"
2023-04-17 22:34:48 DEBUG [iTunes] Podcast search for "pointerpodcast" returned 1 results
2023-04-17 22:34:50 DEBUG [podcastUtils] getPodcastFeed for "https://pointerpodcast.it/index.xml"
2023-04-17 22:34:50 DEBUG [podcastUtils] getPodcastFeed for "https://pointerpodcast.it/index.xml" success - parsing xml
2023-04-17 22:34:57 DEBUG Not modifying permissions since no uid/gid is specified
2023-04-17 22:34:57 DEBUG [fileUtils] Downloading file to /audiobooks/PointerPodcast/cover
2023-04-17 22:34:57 INFO [CoverManager] Downloaded libraryItem cover "/audiobooks/PointerPodcast/cover.jpg" from url "https://is1-ssl.mzstatic.com/image/thumb/Podcasts115/v4/78/f6/9d/78f69dab-dd6e-1a14-8ebd-cbac8156f527/mza_17210995197010023943.png/600x600bb.jpg" for "PointerPodcast"
2023-04-17 22:34:57 DEBUG Not modifying permissions since no uid/gid is specified
2023-04-17 22:34:57 DEBUG [LibraryItem] Success saving abmetadata to "/audiobooks/PointerPodcast/metadata.abs"
2023-04-17 22:34:57 DEBUG [DB] Library Items inserted 1
2023-04-17 22:34:58 DEBUG [FfmpegHelpers] Resize Image Cmd: ffmpeg -i /audiobooks/PointerPodcast/cover.jpg -y -vf scale=400:-1 /metadata/cache/covers/li_3a11fvl1ekhvjfau71_400.webp
2023-04-17 22:34:58 DEBUG [FfmpegHelpers] Image resized Successfully
2023-04-17 22:34:58 DEBUG Not modifying permissions since no uid/gid is specified
2023-04-17 22:34:59 DEBUG [Watcher] File Added /audiobooks/PointerPodcast/cover.jpg
2023-04-17 22:34:59 DEBUG [Watcher] Modified file in library "Podcast" and folder "fol_enusoidc8lkxp5ejra" with relPath "/PointerPodcast/cover.jpg"
2023-04-17 22:34:59 DEBUG [Watcher] File Added /audiobooks/PointerPodcast/metadata.abs
2023-04-17 22:34:59 DEBUG [Watcher] Modified file in library "Podcast" and folder "fol_enusoidc8lkxp5ejra" with relPath "/PointerPodcast/metadata.abs"
2023-04-17 22:35:00 DEBUG [Watcher] File Added /audiobooks/Metadata/cache/covers/li_3a11fvl1ekhvjfau71_400.webp
2023-04-17 22:35:00 DEBUG [Watcher] Modified file in library "Podcast" and folder "fol_enusoidc8lkxp5ejra" with relPath "/Metadata/cache/covers/li_3a11fvl1ekhvjfau71_400.webp"
2023-04-17 22:35:04 INFO [Server] 3 Files Changed
2023-04-17 22:35:04 INFO [Scanner] No important changes to scan for in folder "fol_enusoidc8lkxp5ejra"
2023-04-17 22:35:11 DEBUG [Podcast] Key updated autoDownloadSchedule 40 5 * * 4,5
2023-04-17 22:35:11 DEBUG [Podcast] Key updated maxEpisodesToKeep 3
2023-04-17 22:35:11 INFO [CronManager] Added podcast "PointerPodcast" to auto dl episode cron "40 5 * * 4,5"
2023-04-17 22:35:11 DEBUG [LibraryItemController] Updated library item media PointerPodcast
2023-04-17 22:35:11 DEBUG [LibraryItem] Success saving abmetadata to "/audiobooks/PointerPodcast/metadata.abs"
2023-04-17 22:35:11 DEBUG [DB] Library Items updated 1
2023-04-17 22:35:18 DEBUG [iTunes] Searching for podcast with term "PointerPodcast"
2023-04-17 22:35:18 DEBUG [iTunes] Podcast search for "PointerPodcast" returned 1 results
2023-04-17 22:35:19 INFO [Scanner] Scanning Library Item "PointerPodcast"
2023-04-17 22:35:19 DEBUG [Podcast] "PointerPodcast" changes found in metadata.abs file [object Object]
2023-04-17 22:35:19 DEBUG [PodcastMetadata] Key updated itunesId 1465505870
2023-04-17 22:35:19 DEBUG [LibraryItem] Success saving abmetadata to "/audiobooks/PointerPodcast/metadata.abs"
2023-04-17 22:35:19 DEBUG [DB] Library Items updated 1
2023-04-17 22:35:27 DEBUG [Podcast] Key updated lastEpisodeCheck 1681158840000
2023-04-17 22:35:27 DEBUG [LibraryItemController] Updated library item media PointerPodcast
2023-04-17 22:35:27 DEBUG [LibraryItem] Success saving abmetadata to "/audiobooks/PointerPodcast/metadata.abs"
2023-04-17 22:35:27 DEBUG [DB] Library Items updated 1
2023-04-17 22:35:27 INFO [PodcastManager] checkAndDownloadNewEpisodes for "PointerPodcast" - Last episode check: Mon Apr 10 2023 22:34:00 GMT+0200 (Central European Summer Time)
2023-04-17 22:35:27 DEBUG [podcastUtils] getPodcastFeed for "https://pointerpodcast.it/index.xml"
2023-04-17 22:35:27 DEBUG [podcastUtils] getPodcastFeed for "https://pointerpodcast.it/index.xml" success - parsing xml
2023-04-17 22:35:31 DEBUG [LogManager] Daily log file already exists - set in Logger
2023-04-17 22:35:31 DEBUG [DailyLog] 2023-04-17: Loaded 2366 Logs
2023-04-17 22:35:30 INFO === Starting Server ===
2023-04-17 22:35:30 INFO [Server] Init v2.2.19
2023-04-17 22:35:30 INFO [DB] 0 Collections Loaded
2023-04-17 22:35:30 INFO [DB] 0 Authors Loaded
2023-04-17 22:35:30 INFO [DB] 0 Series Loaded
2023-04-17 22:35:30 INFO [DB] 0 Playlists Loaded
2023-04-17 22:35:31 INFO [DB] 1 Users Loaded
2023-04-17 22:35:31 INFO [DB] 1 Libraries Loaded
2023-04-17 22:35:31 DEBUG Set Log Level to DEBUG
2023-04-17 22:35:31 INFO [DB] 36 Library Items Loaded
2023-04-17 22:35:31 INFO [BackupManager] 0 Backups Found
2023-04-17 22:35:31 INFOn[BackupManager] Auto Backups are disabled
2023-04-17 22:35:31 DEBUG Daily Log file found 2023-04-11.txt
2023-04-17 22:35:31 DEBUG Daily Log file found 2023-04-12.txt
2023-04-17 22:35:31 DEBUG Daily Log file found 2023-04-13.txt
2023-04-17 22:35:31 DEBUG Daily Log file found 2023-04-14.txt
2023-04-17 22:35:31 DEBUG Daily Log file found 2023-04-15.txt
2023-04-17 22:35:31 DEBUG Daily Log file found 2023-04-16.txt
2023-04-17 22:35:31 DEBUG Daily Log file found 2023-04-17.txt
2023-04-17 22:35:31 INFO [LogManager] Init current daily log filename: 2023-04-17.txt
2023-04-17 22:35:31 DEBUG [CronManager] Found 36 podcast episode schedules to start

Screenshot

@advplyr advplyr reopened this Apr 17, 2023
advplyr added a commit that referenced this issue Apr 17, 2023
@advplyr
Fix:Crash when podcasts put empty spaces with episode file path in RS…
0bb1cf0 
…S feed #1650
@advplyr
Copy link
Owner

advplyr commented Apr 17, 2023

There is another issue with this RSS feed that I found. They put an empty space in front of the mp3 file path.

This seems like an error on their side but I updated it so that spaces will be removed.

image

@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Apr 17, 2023
@advplyr
Copy link
Owner

advplyr commented May 5, 2023

Fixed in v2.2.20

@advplyr advplyr closed this as completed May 5, 2023
@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@holazit @advplyr