Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Status finished / partly heard series #1734

Closed
Hallo951 opened this issue Apr 27, 2023 · 9 comments
Closed

[Enhancement]: Status finished / partly heard series #1734

Hallo951 opened this issue Apr 27, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@Hallo951
Copy link
Contributor

Describe the feature/enhancement

It would be very nice to have a visual feature in the series view for series that have been started, just as it is now for series that have been completed. I imagine it like this:

Finished series = green bar (already implemented in the web interface)
Started series = yellow bar (does not exist yet)
Series not started = no bar (already implemented on the web interface)

@Hallo951 Hallo951 added the enhancement New feature or request label Apr 27, 2023
advplyr added a commit that referenced this issue Apr 29, 2023
@advplyr
Copy link
Owner

advplyr commented Apr 29, 2023

This is how I implemented this.

Example 1
1 of the 10 books in this series is finished, the next book hasn't been started yet. (10% yellow progress bar)
image

Example 2
1 book finished, 1 book started. (66% yellow progress bar)
image

Example 3
4 books finished, 1 book started. (100% yellow progress bar)
image

Example 4
All books finished
image

@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Apr 29, 2023
@Hallo951
Copy link
Contributor Author

Hallo951 commented May 1, 2023

Wow, that's really not bad. I'm just not so sure if what you've built isn't a bit too much of a good thing. For example, if you have your case 1, I could imagine that you don't see it at all in the big overview because the bar is so short.

Therefore a new suggestion. How about leaving the bar length always the same and working with different colors instead of the bar length? You could take a color gradient from red to green and then step it every 10% so that you end up with 10 different colors that indicate the hearing progress. I think that would be a bit clearer than changing the bar length.

What do you think about this?

@vsuh
Copy link

vsuh commented May 2, 2023

It seems to me that for the deaf-eyed, a label like "4/6" would be more understandable

@Hallo951
Copy link
Contributor Author

Hallo951 commented May 3, 2023

@advply What do you think about my proposal?

@advplyr
Copy link
Owner

advplyr commented May 3, 2023

I don't think changing the bar color would be more clear then changing the bar length. The bar length is how we currently show progress on individual items.
In addition to the bar length we could change the label "4/6". I'm not sure it would be clear what the "4" means though.

@vsuh
Copy link

vsuh commented May 4, 2023

"4/6" - fourth book of six in this series

@Hallo951
Copy link
Contributor Author

Hallo951 commented May 5, 2023

Is it possible for you to implement a fixed bar length gradient in addition to your solution, so that the display type can be selected in the settings?

This would be great and should not be difficult to implement as you have already implemented your solution.

@advplyr
Copy link
Owner

advplyr commented May 5, 2023

Added in v2.2.20

I didn't have time to revise the current implementation before this release. I'm also not sold on any of the ideas mentioned so I think this will need some more user feedback.
Feel free to open another issue for more updates but try out the current update first. I don't think a color gradient on the progress bar would be added but I'm open to more user feedback.

@advplyr advplyr closed this as completed May 5, 2023
@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label May 5, 2023
@skyzuma
Copy link

skyzuma commented May 6, 2023

i think the best way is the length of the cover ... if we have 6 books: 1st cover = % of cover length (25% = 1/4 of cover length /// 50% = middle of the cover /// 100% = end of the cover) ...

edit: the limit is 10 cover so this would not work, sry ... maybe the numbers ...

and numbers in the line of the titlename maybe a green number for readed book, yellow for "not finished" books and normal (white) color for "not yet readed" ... like:

"titlename (2 (green color) | 2 (yellow color) | 2 (white color (normal color like the titlename)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants