Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort Book Match Results by closest to length #2238

Closed
PulsarFTW opened this issue Oct 22, 2023 · 2 comments · Fixed by #2400
Closed

Sort Book Match Results by closest to length #2238

PulsarFTW opened this issue Oct 22, 2023 · 2 comments · Fixed by #2400
Labels
enhancement New feature or request

Comments

@PulsarFTW
Copy link

The new book length on the match page is excellent. A potention suggestion for improvement: Once a list of results has been found for a book, rather than the default ordering from the provider, organise them from closest to book length to biggest difference.
@PulsarFTW PulsarFTW added the enhancement New feature or request label Oct 22, 2023
@advplyr advplyr transferred this issue from advplyr/audiobookshelf-app Oct 22, 2023
@mikiher
Copy link
Contributor

mikiher commented Nov 30, 2023

I will pick this one.

I think it's best to implement this on the server. It requires some changes in the search API so it also accepts the libraryItemId as a parameter.

@mikiher mikiher mentioned this issue Dec 8, 2023
Merged
advplyr added a commit that referenced this issue Dec 10, 2023
@advplyr
Merge pull request #2400 from mikiher/bookfinder-improvements
6abc081 
A few BookFinder improvements (including a fix for #2238)
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Dec 10, 2023
@advplyr
Copy link
Owner

advplyr commented Dec 24, 2023

Added in v2.7.0

@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A few BookFinder improvements (including a fix for #2238) mikiher/audiobookshelf
3 participants
@mikiher @advplyr @PulsarFTW