Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Have your stats display thousands with a comma #3187

Closed
ZLoth opened this issue Jul 21, 2024 · 4 comments
Closed

[Enhancement]: Have your stats display thousands with a comma #3187

ZLoth opened this issue Jul 21, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@ZLoth
Copy link

ZLoth commented Jul 21, 2024

Type of Enhancement

Web Interface/Frontend

Describe the Feature/Enhancement

This is similar to implemented suggestion [Enhancement]: Have library stats display thousands with a comma #2861. Simply put, if a number is in the thousands, add a comma to enhance readability.

Why would this be helpful?

It is easier to read.

Future Implementation (Screenshot)

image

Audiobookshelf Server Version

2.11.0

Current Implementation (Screenshot)

image

image

@ZLoth ZLoth added the enhancement New feature or request label Jul 21, 2024
@lkjfdsaofmc
Copy link

If this were to be implemented it should be noted some regions would need an option to have this display via periods instead of comma's. (1.000 instead of 1,000)

@ZLoth
Copy link
Author

ZLoth commented Jul 22, 2024

If this were to be implemented it should be noted some regions would need an option to have this display via periods instead of comma's. (1.000 instead of 1,000)

This was addressed in the original feature request involving library stats that I linked to this request.

@advplyr
Copy link
Owner

advplyr commented Jul 22, 2024

If this were to be implemented it should be noted some regions would need an option to have this display via periods instead of comma's. (1.000 instead of 1,000)

Number formatting uses the language setting

@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Jul 22, 2024
glorenzen pushed a commit to glorenzen/audiobookshelf that referenced this issue Jul 24, 2024
Copy link

github-actions bot commented Aug 4, 2024

Fixed in v2.12.0.

@github-actions github-actions bot closed this as completed Aug 4, 2024
@github-actions github-actions bot removed the awaiting release Issue is resolved and will be in the next release label Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants