Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement to Manual Match: Allow user to revert to existing data via click #3200

Closed
iconoclasthero opened this issue Jul 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@iconoclasthero
Copy link

iconoclasthero commented Jul 28, 2024

Type of Enhancement

Web Interface/Frontend

Describe the Feature/Enhancement

12:39 PM]iconoclast hero: i'm thinking of making the existing data a hyperlink that when you click on it it reverts to the exiting data and leaves the box checked

Why would this be helpful?

[11:31 AM]iconoclast hero: why not just uncheck the box? then it's unchecked for the next entry which inevitably leads to forgetting that a change that was desired to be temporary is now persistent.
[11:36 AM]DieselTech: Yeah it being unchecked for the next one is the problem here
[11:36 AM]DieselTech: Especially when the modal doesn't show all the data in 1 shot

Future Implementation (Screenshot)

[11:29 AM]iconoclast hero: so i do not, but let's say I wanted to keep the exiting title with the subtitle and date included. if that was clickable so that it would revert to that entry and leave that option checked for the next match, and ALSO allow me to edit the reverted entry, that would be helpful here.
Screenshot from 2024-07-28 11-28-06

[11:31 AM]iconoclast hero: the most likely place i would use it is on the date field.
Screenshot from 2024-07-28 11-30-10

[11:31 AM]iconoclast hero: why not just uncheck the box? then it's unchecked for the next entry which inevitably leads to forgetting that a change that was desired to be temporary is now persistent.
[11:36 AM]DieselTech: Yeah it being unchecked for the next one is the problem here
[11:36 AM]DieselTech: Especially when the modal doesn't show all the data in 1 shot
[11:37 AM]iconoclast hero: ok so if no one who's more active in the git issues remembers such an FR, I'll search & submit in a bit.
[11:57 AM]advplyr: Would it be preferable to not remember the previously unchecked fields? I think I originally made that persist by request.
[12:00 PM]DieselTech: Problem with that is like he said, you don't always remember you had to uncheck something to prevent bad metadata from getting entered
[12:00 PM]DieselTech: And without seeing all the options at the same time you don't know
[12:00 PM]DieselTech: You have to scroll to page to see it all, even on a large screen
[12:02 PM]DieselTech:
Image
[12:02 PM]nyxholas (nichwall): The top check mark is "select/deselect all", could that just be changed to not be true any item is not checked?
[12:02 PM]DieselTech: Small pop up vs screen size
[12:04 PM]nyxholas (nichwall): Oh, that is how works, nevermind
[12:04 PM]DieselTech: Also that seems to be the case, yeah
[12:04 PM]DieselTech: Maybe listing something that is unchecked at the top?
[12:05 PM]DieselTech: Like "The following fields are unchecked: Cover Image"
[12:05 PM]justcallmelarry: i almost never want to copy cover, but sometimes i do (when one is missing for example)

having a default setting somewhere and then not remembering the current checkmarks would be ideal for my workflow
[12:05 PM]DieselTech: That way fields that are unselected below the scroll bar can be known
[12:06 PM]justcallmelarry: or having two checkboxes, one for current and one for default setting, but not sure how to make that look intuitive at all
[12:39 PM]iconoclast hero: I think that the reversion would be preferable in cases where you'd want to edit the existing rather than take the matched data.
[12:39 PM]iconoclast hero: i'm thinking of making the exisitng data a <u>hyperlink</u>* that when you click on it it reverts to the exiting data and leaves the box checked
[12:40 PM]iconoclast hero: it seems to me like THE minimal amount of change to the UI and also a limited amount of programming to make it happen.

Audiobookshelf Server Version

v2.11.0 docker

Current Implementation (Screenshot)

See above.

*Markdown doesn't have underline?

@iconoclasthero iconoclasthero added the enhancement New feature or request label Jul 28, 2024
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Jul 29, 2024
Copy link

github-actions bot commented Aug 4, 2024

Fixed in v2.12.0.

@github-actions github-actions bot closed this as completed Aug 4, 2024
@github-actions github-actions bot removed the awaiting release Issue is resolved and will be in the next release label Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants