Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ABS recognises every 10 letter title as a valid ASIN while matching #3314

Closed
WeisseTeetasse opened this issue Aug 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@WeisseTeetasse
Copy link

WeisseTeetasse commented Aug 20, 2024

What happened?

Given a 10 letter book title, ABS searches for ASIN instead of the book title when matching.

What did you expect to happen?

ABS should search for title instead of ASIN

Steps to reproduce the issue

  1. match a book with a 10 letter title, like Yellowface by R.F. Kuang
  2. nothing is found

Audiobookshelf version

v2.12.3

How are you running audiobookshelf?

Docker

What OS is your Audiobookshelf server hosted from?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

None

Logs

{"timestamp":"2024-08-20 14:10:19.297","source":"Audible.js:110","message":"[Audible] ASIN search error AxiosError: Request failed with status code 400","levelName":"ERROR","level":4}

Additional Notes

Error is in https://github.com/advplyr/audiobookshelf/blob/master/server/utils/index.js
Replacing the regexp with return /^A-Z(?=.*\d)[A-Z0-9]{9}$/.test(str) works for me.
There are still some exceptions like https://www.audible.com/pd/The-Fellowship-of-the-Ring-Audiobook/0008487278

@WeisseTeetasse WeisseTeetasse added the bug Something isn't working label Aug 20, 2024
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Aug 20, 2024
Copy link

Fixed in v2.13.0.

@github-actions github-actions bot removed the awaiting release Issue is resolved and will be in the next release label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants