Add Source to Logging #1367
Add Source to Logging #1367
Conversation
The Audiobookshelf logs sometimes contain information about the source of the log statement, but sometimes they don't This really depends on developers adding these information to the log messages. But even then, the information is usually just a hint about the module logging this, like `[Db]` or [Watcher]`, and finding the exact line can be hard. This patch automatically adds the source of the log statement to the logs. This means if someone calls `Logger.info(…)` in line `22` of `foo.js`, the log statement will contain this file and line: ``` [2023-01-05 19:04:12[ (LogManager.js:85:18) DEBUG: Daily Log file found 2023-01-05.txt [2023-01-05 19:04:12] (LogManager.js:59:12) INFO: [LogManager] Init current daily log filename: 2023-01-05.txt ``` This should make it much easier to identify the code where the log statement originated from. Long-term, this also means that we can probably remove the manually set identifiers contained in the log messages, like the `[LogManager]` in the example above.
|
I like it. I didn't think to catch the stack trace like that. I do prefer some updates to it and fixed it so it works on Windows. Putting it at the end of the log line and not including it for I set a variable to detect if this is windows |
|
Sorry about Windows. I forgot about the file path being different there. And I don't have a Windows at hand to test…
Do you have strong feelings about not including this for |
|
We could include it for |
|
Let's not do that. I suspect that in dev mode it's less often that you work with logs and it's always somewhat confusing if an application behaves differently if different environments. I'd rather avoid that if there is no good reason. But I guess, I can always fall back to the log files where the info is included after all. |
The Audiobookshelf logs sometimes contain information about the source of the log statement, but sometimes they don't This really depends on developers adding these information to the log messages.
But even then, the information is usually just a hint about the module logging this, like
[Db]or [Watcher]`, and finding the exact line can be hard.This patch automatically adds the source of the log statement to the logs. This means if someone calls
Logger.info(…)in line22offoo.js, the log statement will contain this file and line:This should make it much easier to identify the code where the log statement originated from.
Long-term, this also means that we can probably remove the manually set identifiers contained in the log messages, like the
[LogManager]in the example above.