Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Progress for EPUBs #1627

Merged
merged 6 commits into from
Mar 24, 2023
Merged

Save Progress for EPUBs #1627

merged 6 commits into from
Mar 24, 2023

Conversation

vincentscode
Copy link
Contributor

As discussed here the EPUB Reader in its current form is hardly usable.
I think moving forward EPUB.js is still our best choice for reading EPUBs as it is also used by calibre web for example.

This pull implements persistent progress for EPUBs so reading can be resumed which is one of the biggest problems at the moment (#75 (comment)).

It also lays the groundwork for other features such as text size control or a ToC.

@advplyr
Copy link
Owner

advplyr commented Mar 21, 2023

Thanks, this is a great start. What is the benefit of storing the locations in duration?

We'll need to update the data model for media progress since a library item can have an ebook and audiobook.

Add Table of Contents
@vincentscode
Copy link
Contributor Author

I've modified the code to use ebook specific fields for progress now. I've also added a simple sidebar with a table of contents.

@advplyr
Copy link
Owner

advplyr commented Mar 24, 2023

Thanks, it is working great in my testing.

There are a few things we may want to address before the release but can be done separate from this. I'll have to think on it and message in Discord.

Also, if you are using VSCode there is a settings.json there and if you have vetur extension installed it should follow the same formatting used in the rest of the project. It is harder to see the changes being made when we are using different formatting.

@advplyr advplyr merged commit c89d77d into advplyr:master Mar 24, 2023
@vincentscode vincentscode deleted the epub-reader branch March 24, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants