Fix: apply base path to client and websocket #1724
Conversation
| @@ -368,14 +368,15 @@ export default { | |||
| initializeSocket() { | |||
| this.socket = this.$nuxtSocket({ | |||
| name: process.env.NODE_ENV === 'development' ? 'dev' : 'prod', | |||
| channel: this.$config.routerBasePath, | |||
There was a problem hiding this comment.
This selects the "basePath" for sockets
server/Server.js
Outdated
| const replaceUrls = new RegExp(`((?:href|src|url|scope)"?(?:=|:)\\s*["'](?:http://localhost:3333)?)${currentBasePath || "/"}([^"']*["'])`, "g") | ||
| const replaceNuxtConfig = new RegExp(`<script>window.__NUXT__=.*?</script>`, "g") | ||
| const replaceAssetPaths = new RegExp(`${currentBasePath}/(_nuxt/[^"]*|sw.js)`, "g") |
There was a problem hiding this comment.
I looked through every single change this made, and they all looked fine. No guarantee though that it will stay this way, nor that it will always catch every path to be updated.
| cors: { | ||
| origin: '*', | ||
| methods: ["GET", "POST"] | ||
| } | ||
| }) | ||
| })).of(global.RouterBasePath || "/") |
There was a problem hiding this comment.
This will always use the base path as namespace
|
Awesome, this is working in my quick test. I'll have to do more testing when I have time. I spotted one path for the comic reader that still needs to get updated https://github.com/advplyr/audiobookshelf/blob/master/client/components/readers/ComicReader.vue#L59 Thanks for getting this moving along! |
|
The |
1nVitr0
force-pushed
the
master
branch
3 times, most recently
from
29cd63a
to
667f58d
Compare
|
@advplyr I guess we close this? Feel free to do so 😄 |
Adresses #385
Although in my tests this seems to work reliably, this is at best a temporary solution. As discussed in #385, this should be replaced by a long-term solution, such as running nuxt programatically or as it's own thread and proxying requests to it.
Feel free to absolutely obliterate it, or keep this open until the long-term solution is finished. I think we should decide on a direction before I begin tackling that one.
Also, this was done outside the development container (Node 16.20, Ubuntu 22.04), so you might want to look over the lockfile.