Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update material icons #3138

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Update material icons #3138

merged 10 commits into from
Jul 10, 2024

Conversation

glorenzen
Copy link
Contributor

This pull request adds font files for Material Symbols to replace the Material Icons fonts, which are deprecated.

The Material Icons files and classes are still there, but I have added new Material Symbols font files and replaced all material-icons CSS classes with new material-symbols classes.

@glorenzen glorenzen marked this pull request as ready for review July 8, 2024 20:31
@advplyr
Copy link
Owner

advplyr commented Jul 8, 2024

Thanks this is a nice update. The YearInReview components also use material icons in canvas. It should be able to get updated the same way

@glorenzen
Copy link
Contributor Author

Awesome, I just updated the YearInReview components and a couple of others that I missed. That should be all of them now.

@glorenzen
Copy link
Contributor Author

I know this hasn't been open for very long, but would it be possible to have this reviewed/merged soon? I'd like to use a few of the Material Symbols in my other PR #3113 :)

@mfcar
Copy link
Contributor

mfcar commented Jul 10, 2024

I think it would be nice to add the link for the icon set in the README or the contributing pages.
For the old icon set, I always forgot the set name and struggled to find the link for the gallery.

@glorenzen
Copy link
Contributor Author

@mfcar Do you mean add this link to the Contributing section at the end of the README? https://fonts.google.com/icons

@advplyr
Copy link
Owner

advplyr commented Jul 10, 2024

Great, thanks!

@advplyr advplyr merged commit acaf1ac into advplyr:master Jul 10, 2024
4 checks passed
@glorenzen glorenzen deleted the update-material-icons branch July 14, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants