Fix permission issues in embed/merge #3204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3146.
This changes the way the output of the embedding/merging tools is written back to the original directory, so that the permissions of the original audio files are kept intact.
Before this, we used fs.move(), which moved the ffmpeg output to the original file, effectively replacing the original permissions with whatever permissions the ffmpeg process assigned to its output file. Instead, we now pipe the contents of the ffmpeg output into the original file, so the contents of the original file are replaced but all file attributes (e.g. permissions) remain intact.