Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission issues in embed/merge #3204

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

mikiher
Copy link
Contributor

@mikiher mikiher commented Jul 29, 2024

This fixes #3146.

This changes the way the output of the embedding/merging tools is written back to the original directory, so that the permissions of the original audio files are kept intact.

Before this, we used fs.move(), which moved the ffmpeg output to the original file, effectively replacing the original permissions with whatever permissions the ffmpeg process assigned to its output file. Instead, we now pipe the contents of the ffmpeg output into the original file, so the contents of the original file are replaced but all file attributes (e.g. permissions) remain intact.

@mikiher mikiher marked this pull request as ready for review July 29, 2024 17:53
@advplyr
Copy link
Owner

advplyr commented Jul 29, 2024

Thanks!

@advplyr advplyr merged commit a77f4e9 into advplyr:master Jul 29, 2024
4 checks passed
@mikiher mikiher deleted the embed-permissions branch August 1, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Book file inaccessible outside ABS after using "embed metadata" due to permissions change
2 participants