Fix unicode.so loading #3236
Merged
Fix unicode.so loading #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 5, 2024
|
Nice! have you tested this? So, if I read your comment correctly, this is not about arm64, it's about systems that don't have glibc? |
|
@mikiher Yes! I'm not exactly sure why other architectures seem to be able to load it (for now!), but they could break and installing the compatibility layer is the safe choice for the future. 
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unicode.sois dynamically linked against glibc but Alpine only comes with musl. Installing the compatibility layer fixes it.Fix #3231
Fix #3234
Close #3235