Fix tag permissions #3368
Merged
Fix tag permissions #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3365
This PR updates the default User model to include
selectedTagsNotAccessibleon the default user creation. Thepatchrequest for/api/users/{id}is also updated to compare the payload against the default permissions to allow for values to be updated by clients on existing users which do not have the key in thepermissionsarray. I'm not sure if that's the best way to do this, but figured it was more secure to validate against the default properties instead of allowing arbitrary keys to be created by a client.This does not go through and update existing users which do not have
selectedTagsNotAccessible.