Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_common_impl seems to be missing a use super::* #22

Closed
pedrohjordao opened this issue Jul 16, 2018 · 6 comments
Closed

generate_common_impl seems to be missing a use super::* #22

pedrohjordao opened this issue Jul 16, 2018 · 6 comments

Comments

@pedrohjordao
Copy link
Contributor

Hi,

After I updated the nightly compiler version I started getting the following error:

    |
126 | #[derive(DbEnum, Serialize, Deserialize, Debug, PartialEq, Clone)]
    |          ^^^^^^ Use of undeclared type or module `TipoInterface`

Looking into the generated code, indeed there was a missing use super::* so the enum name was visible inside the generated code. That fix seems simple enough, so I will open a pull request, if that's alright.

@adwhit
Copy link
Owner

adwhit commented Jul 17, 2018

Interesting. Obviously updating nightly shouldn't be a breaking change. Perhaps I need to update quote and syn. Anyway thanks for the PR

@adwhit
Copy link
Owner

adwhit commented Jul 17, 2018

I think it was this: rust-lang/rust#50504

@pedrohjordao
Copy link
Contributor Author

Seems like it.

Quick question: any time frame for publishing the fix on crates.io?

@adwhit
Copy link
Owner

adwhit commented Jul 17, 2018

I think I'll push out 0.4.4 in the next few hours

@adwhit
Copy link
Owner

adwhit commented Jul 17, 2018

Done

@pedrohjordao
Copy link
Contributor Author

pedrohjordao commented Jul 17, 2018 via email

lucab added a commit to lucab/fero that referenced this issue Nov 6, 2018
This fixes a build failure on current stable Rust (1.30.0) due
to adwhit/diesel-derive-enum#22.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants