Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fat aar] Android .aar module dependency support #77

Merged
merged 3 commits into from
Aug 24, 2017

Conversation

mfdeveloper
Copy link
Contributor

Using the fat-aar.gradle tasks to generate a .aar from a module/project that declare others modules that have a .aar file defined like a artifact, throws erros in many of tasks.

This PR enable support for this situtation. The changes below were did:

@mfdeveloper
Copy link
Contributor Author

Hello @adwiv ! This project is mainteined yet?

@oscarcpozas
Copy link

Hey @mfdeveloper, seems to be abandoned this repository but I would like use this plugin. Publish your fork and merge other issues resolve for other PRs, it's good option.

@adwiv
Copy link
Owner

adwiv commented Aug 21, 2017

Hi, I have merged two pull requests due to which this request now has conflicts. Can you please merge and send a new request.

@oscarcpozas
Copy link

Oh perfect, thanks!

@mfdeveloper mfdeveloper force-pushed the aar-module-dependency branch from c1d4991 to a251bb1 Compare August 23, 2017 12:43
@mfdeveloper mfdeveloper force-pushed the aar-module-dependency branch from a251bb1 to e4e231f Compare August 23, 2017 13:52
@mfdeveloper
Copy link
Contributor Author

Roger that @adwiv !! I've resolved merge conflicts. Please, see the new changes 😃

@adwiv adwiv merged commit 5e1e251 into adwiv:master Aug 24, 2017
@adwiv
Copy link
Owner

adwiv commented Aug 24, 2017

Thanks @mfdeveloper, merged the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants