Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests #6

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Update tests #6

merged 1 commit into from
Feb 26, 2024

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break santaR.

Several tests had expectations that the result of plot objects had length 9. This assumption no longer holds in the new version of ggplot2, so this PR updates these tests to test for the same length as ggplot() results.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help santaR get out a fix if necessary.

@adwolfer
Copy link
Owner

Thank you @teunbrand for the reverse-dependency check and the PR addressing it, very much appreciated. We will update santaR accordingly.

@adwolfer adwolfer self-assigned this Jan 21, 2024
@teunbrand
Copy link
Contributor Author

Looking back at this, I apologise for the many spurious changes. Many of these are due to my editor stripping trailing whitespace when saving scripts and ought to be safely ignoreable.

@teunbrand
Copy link
Contributor Author

This is just a kind reminder that the release of ggplot2 is scheduled soon.

@adwolfer adwolfer merged commit 7367dc4 into adwolfer:master Feb 26, 2024
@teunbrand teunbrand deleted the ggplot2_3.5.0 branch February 26, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants