-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send notification content through Firebase and add an Arq scheduler #613
base: main
Are you sure you want to change the base?
Conversation
e9e646b
to
07a5ce5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
- Coverage 81.31% 80.99% -0.33%
==========================================
Files 129 130 +1
Lines 10013 10116 +103
==========================================
+ Hits 8142 8193 +51
- Misses 1871 1923 +52 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test that tries to defer a method using the scheduler
) | ||
scheduler_logger.debug(f"Job {job_id} queued {job}") | ||
|
||
async def queue_job_defer_to( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a real interest in keeping both queue_job_time_defer
and queue_job_defer_to
?
I think we are likely to calculate defer_seconds
using a timedelta
and datetime
, and thus could easily use queue_job_defer_to
instead.
It seems Arq will calculate a datetime
in both cases, so there shouldn't be a performance gain from using a method or the other.
I would think only having one method will reduce code complexity and limit potentials mistakes
06188e2
to
2002603
Compare
Co-authored-by: Armand Didierjean <95971503+armanddidierjean@users.noreply.github.com>
Co-authored-by: Armand Didierjean <95971503+armanddidierjean@users.noreply.github.com>
Simplifying expression Co-authored-by: Armand Didierjean <95971503+armanddidierjean@users.noreply.github.com>
4cadc2f
to
0eb2466
Compare
as the new structure does not require it
instead of default value
No description provided.