Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Responsive login page #317

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: Responsive login page #317

wants to merge 5 commits into from

Conversation

guillaumetavernier
Copy link
Contributor

@guillaumetavernier guillaumetavernier commented Mar 3, 2024 •
edited
Loading

image
image
image

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.01%. Comparing base (3791c95) to head (4694cc0).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
- Coverage   56.03%   56.01%   -0.02%     
==========================================
  Files         161      161              
  Lines        3514     3515       +1     
==========================================
  Hits         1969     1969              
- Misses       1545     1546       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guillaumetavernier guillaumetavernier changed the title feat: Responsive login page first iteration feat: Responsive login page Mar 3, 2024
julien4215
julien4215 requested changes Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@julien4215 julien4215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before : image
After : image

I think it looked better before

@maximeroucher maximeroucher self-requested a review March 10, 2024 15:47
@armanddidierjean armanddidierjean marked this pull request as draft March 15, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien4215 julien4215 julien4215 requested changes

@maximeroucher maximeroucher Awaiting requested review from maximeroucher

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guillaumetavernier @codecov-commenter @maximeroucher @julien4215