Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis #4

Open
wants to merge 3 commits into
base: 7.x-3.x
Choose a base branch
from
Open

Fix travis #4

wants to merge 3 commits into from

Conversation

jonpugh
Copy link
Member

@jonpugh jonpugh commented Aug 10, 2016

Fixing travis yml.

Use the new 'prepare-docker.sh' script, and the docker-compose-hostmaster.yml file.

@helmo
Copy link
Member

helmo commented Aug 16, 2016

@jonpugh can we run the install with --verbose? or even debug?
Maybe via a $AEGIR_INSTALL_EXTRA_OPTIONS variable?

@jonpugh
Copy link
Member Author

jonpugh commented Aug 16, 2016

@helmo That would be good for testing, but not for local development or production docker.

Maybe we can create a separate "tag" for a docker image with extra debug info.

Go ahead and submit a PR for the "dockerfiles" repo, alter the docker-entrypoint-tests.sh scipt: https://github.com/aegir-project/dockerfiles/blob/master/docker-entrypoint-tests.sh
That way we can see what it looks like in travis.

I'm ok with making that an easy option, but I think keeping the docker logs clean is better developer experience (once we have stable containers of course.)

@jonpugh
Copy link
Member Author

jonpugh commented Aug 16, 2016

I tracked down when Hostmaster started failing: https://travis-ci.org/aegir-project/hostmaster/builds/150880346

It was when we committed node_access_rebuild(). 84db208...b90c772

So I'm going to test out removing it.

@jonpugh
Copy link
Member Author

jonpugh commented Aug 16, 2016

meh, as I feared, the problem is not in the commit, but in a change to tests or dockerfiles...

At least we know the timestamp now :)

@jonpugh
Copy link
Member Author

jonpugh commented Aug 16, 2016

Ok, this seems like a problem with drush make itself.

I've narrowed down the issue to profile projects using the "copy" download type.

See this issue: drush-ops/drush#2311 (comment)

@jonpugh
Copy link
Member Author

jonpugh commented Aug 16, 2016

Try manually building the build-hostmaster-local.make file, and you'll see there is no hostmaster profile to run.

@jonpugh
Copy link
Member Author

jonpugh commented Aug 16, 2016

Ok, I found the workaround needed for the makefile.

Here it goes!

@jonpugh
Copy link
Member Author

jonpugh commented Aug 16, 2016

And that's why we test failures!

The tests were not using the local makefile. I believe I have fixed this by setting all environment variables for the run of docker-entrypoint.sh inside docker-entrypoint-tests.sh

@helmo
Copy link
Member

helmo commented Aug 18, 2016

That last commit added a lot of noise ... but I hope it helps find our bug or typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants