-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement reusing of async jobs for equivalent requests. #1414
Conversation
…f RequestTags dependent on the state of the database.
…alls supporting async execution.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
============================================
+ Coverage 85.43% 85.49% +0.06%
Complexity 135 135
============================================
Files 337 339 +2
Lines 7751 7793 +42
Branches 515 518 +3
============================================
+ Hits 6622 6663 +41
Misses 839 839
- Partials 290 291 +1
☔ View full report in Codecov by Sentry. |
…equest case-insensitive.
# Conflicts: # fhir-server/src/main/java/au/csiro/pathling/aggregate/AggregateProvider.java # fhir-server/src/test/java/au/csiro/pathling/test/integration/AsyncTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @piotrszul, I've added a few comments / questions.
Once these have been looked at, I think the best way to prove this out is to merge to a release branch and deploy the pre-release image with a conventional cache setup. We will need to do this for both unauthenticated and authenticated configurations.
I have created a couple of related issues that will need to be resolved before this change can be deployed:
- aehrc/pathling-helm#2
- aehrc/pathling-deployment#6
fhir-server/src/main/java/au/csiro/pathling/async/RequestTagFactory.java
Outdated
Show resolved
Hide resolved
fhir-server/src/main/java/au/csiro/pathling/async/RequestTagFactory.java
Outdated
Show resolved
Hide resolved
…udedFromCacheKey` and added documentation for it. Removed principal from the asyn request cache key it duplicated the Authorization header (for Jwt).
…m async cache keys.
I've moved the Helm chart into the main repository, and I've decided to defer the update of the configuration management for now. I've merged this into the 6.4.0 release. |
Resolves #1313.