Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/3.0.x #6

Merged
merged 9 commits into from
Sep 18, 2019
Merged

Conversation

aelibyary
Copy link
Owner

Summary

tingung and others added 9 commits September 17, 2019 15:54
* DNN-33050 - Trigger reloadPortalList event with portalId and cultureCode

* DNN-33050 - Invoke getPortalSettings with current selected portalId and
cultureCode instead of getPortals which always point to current running
portal
- This is to load the correct portal settings based on user selection
when view portal settings
* DNN-9532 - Fix to display IP Filter settings correctly
- Code refactor and minor bugs listed below
- Update state with the value from json response to ensure IP Filter
object in UI is updated
- Move specificityOptions and typeOptions initialization to constructor
- Move all the validation of the form upon saving to reduce code complexity
- Replace toggle option of RuleSpecificity to use const String of
IP_RANGE and  SINGLE_IP to make the code simpler and more readable
- Move code to clear SubnetMask just before update to prevent SubnetMask
become blank when user switch in between IP_RANGE and SINGLE_IP option

* DNN-9532 - Remove unnecessary blank line
@aelibyary aelibyary merged commit e98f7cb into aelibyary:release/3.0.x Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants