Update forked Dnn.Platform with latest from dnnsoftware #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Get rid of old stuff * Deleted dist folder * added dist folder to gitignore
Restructure AE Extensions into a single VS Project.
Update development with fixes from v9.3.2-rc
…d add in additional react projects (EditBar and React.Common).
Add "remove deleted users" button to place you'd expect it
Fixes errors with previous build scripts following PB merge
* Updates documentation as per recent changes * Added version information * Removed unneeded BuildAll parameter * Added back how to clean * Was already clearer
* Update bug report issue template Replace "nightly build" phrase with "non-release build". Resolves #3172 * Update bug-report.md Use "alpha" instead of "non-release".
…rting the thread (#3152)
* Update "help and other questions" issue template Replace "nightly build" phrase with "non-release build". Resolves #3174 * Update help-and-other-questions.md Use "alpha" instead of "non-release".
* Update "request for comments" issue template Replace "nightly build" phrase with "non-release build". Resolves #3176 * Update request-for-comments.md Use "alpha" instead of "non-release".
* Remove disposal of MemoryStream for email attachments sent using SendtokenizedBuilkEmail * Corrected references to older site URL (#3056) * Corrected references to older site URL * corrected typo from replacement of registered character * Made the BuildAll task default + docs * Fixed a typo * Update .github/BUILD.md Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Update .github/BUILD.md Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Remove reference to empty fs npm package (#3094) fs is a core package, and the version on the npm registry is just an empty package; this was almost certainly added accidentally Fixes #3091 * Added defensive coding to prevent memory leaks * Updates .Net 4.7.2 warning for NL and DE languages (#3032) * Updated de-DE text As per Sebastian Leupold translation * Updated nl-NL warning about .Net 4.7.2 As per Timo Breumelhof translation * DNN-29557 - Infinite while loop fix (#3123) * Update Pages.resx SEO tip for creating a title (cherry picked from commit 04d1ee6) * DNN-31121 - Fix the non alphanumeric character regex (#3059) * DNN-7818: add send verification mail link in unverified message. * Add 'fileName' to condition when checking request for logo file. * Permissions for default folders (#3024) (cherry picked from commit e77a281) * DNN-32978 Copying pro html module don't modify the permission * Fixes errors with previous build scripts following PB merge * Updates issue templates and build docs (#3165) * Updates documentation as per recent changes * Added version information * Removed unneeded BuildAll parameter * Added back how to clean * Was already clearer * Documentation action cleanup (#3171) * Add validation method with IsNullOrWhiteSpace check. Use method to validate RoleGroup Name. closes #2927 (#3170) * OAuthClientBase now returns the correct RequestingCode instead of aborting the thread (#3152)
* Added INavigationManager and updated Globals to reference new INavigationManager * Updated CreateModule to use new INavigationManager * Deprecated NavigateURL for v11.0 * Updated viewsource to use INavigationManager * Migrated Globals.NavigateUrl to use INavigationManager * Updated persona bar controllers to use NavigateUrl * Refactored NavigateURL to use new INavigationManager * Refactored Globals.NavigateURL -> INavigationManager * Refactored more NavigationManager usages * Updated more references to Globals.NavigateURL to use INavigationManager * Cleaned up mistakes that happened in config files in csproj files. These changes were auto-generated by visual studio and shouldn't have been made * removed generated nodes from csproj * Fixed spacing in web.config * Updated old Globals.NavigateURL methods to use registered INavigationManager so everything will execute the same code path * Updated INavigationManager reference to be static readonly instead of an instance property * Aliased Constants to 'Dnn.PersonaBar.Libary.Constants' to handle ambiguity * Added DependencyInjection to website project and updated RazorHost and Export * Updated DotNetNuke.Website Globals.NavigateURL references to use the new INavigationManager * Added missing using statement * Fixing typo Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Removing whitespace Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Fix typo * Use GetRequiredService for INavigationManager Rather than waiting for a null reference later when it's used, there's never a scenario where this dependency is expected to be missing, so we want to indicate that it's expected and recieve an error right away if there's an issue * Added new DotNetNuke.Abstractions project for storing different common abstractions for the platform * Updated all (non website project) classes to use INavigationManager from the new DotNetNuke.Abstractions project * Updated Website Project to use the INavigationManager from the new DotNetNuke.Abstractions project * Removed unnecessary attributes from NavigationManager * Updated redirection controller tests to mock out the DependencyProvider and the INavigationManager to fix failing unit tests * Fixed failing unit tests with mocking out INavigationManager * Removed private fields for DependencyProvider * Added singleton clear statements to prevent the INavigationManager from remaining in memory and conflicts between unit tests * Reset singleton state for PortalController to reduce side-effects from other tests and stale object state from Dependency Injection * Moved state cleanup code to teardown routine * Fixed failing unit tests in tests.web project. Added mocks for INavigationManager so the DepenencyProvider can resolve * Added new DotNetNuke.Abstractions.nuspec to create NuGets during build * Added missing nuspec files to the solution file * Updated copyright on all nuget files * Added .NET Foundation file headers to new Abstraction files * Resolved duplicate addition of DotNetNuke.Abstractions to sln file * Added SetTestableInstance and Clear methods to make it easier to test Components. The new methods are internal * Added happy path test for Navigation Manager * Added NavigationManager tests * Updated all INavigationManager references in .ascx.cs files to use private readonly since there should never be a child class * Removed extra's added by visual studio to .csproj files
* Remove disposal of MemoryStream for email attachments sent using SendtokenizedBuilkEmail * Corrected references to older site URL (#3056) * Corrected references to older site URL * corrected typo from replacement of registered character * Made the BuildAll task default + docs * Fixed a typo * Update .github/BUILD.md Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Update .github/BUILD.md Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Remove reference to empty fs npm package (#3094) fs is a core package, and the version on the npm registry is just an empty package; this was almost certainly added accidentally Fixes #3091 * Added defensive coding to prevent memory leaks * Updates .Net 4.7.2 warning for NL and DE languages (#3032) * Updated de-DE text As per Sebastian Leupold translation * Updated nl-NL warning about .Net 4.7.2 As per Timo Breumelhof translation * DNN-29557 - Infinite while loop fix (#3123) * Update Pages.resx SEO tip for creating a title (cherry picked from commit 04d1ee6) * DNN-31121 - Fix the non alphanumeric character regex (#3059) * DNN-7818: add send verification mail link in unverified message. * Add 'fileName' to condition when checking request for logo file. * Permissions for default folders (#3024) (cherry picked from commit e77a281) * DNN-32978 Copying pro html module don't modify the permission * Fixes errors with previous build scripts following PB merge * Updates issue templates and build docs (#3165) * Updates documentation as per recent changes * Added version information * Removed unneeded BuildAll parameter * Added back how to clean * Was already clearer * Documentation action cleanup (#3171) * Add validation method with IsNullOrWhiteSpace check. Use method to validate RoleGroup Name. closes #2927 (#3170) * OAuthClientBase now returns the correct RequestingCode instead of aborting the thread (#3152) * Created INavigationManager to replace Globals.NavigateURL (#3160) * Added INavigationManager and updated Globals to reference new INavigationManager * Updated CreateModule to use new INavigationManager * Deprecated NavigateURL for v11.0 * Updated viewsource to use INavigationManager * Migrated Globals.NavigateUrl to use INavigationManager * Updated persona bar controllers to use NavigateUrl * Refactored NavigateURL to use new INavigationManager * Refactored Globals.NavigateURL -> INavigationManager * Refactored more NavigationManager usages * Updated more references to Globals.NavigateURL to use INavigationManager * Cleaned up mistakes that happened in config files in csproj files. These changes were auto-generated by visual studio and shouldn't have been made * removed generated nodes from csproj * Fixed spacing in web.config * Updated old Globals.NavigateURL methods to use registered INavigationManager so everything will execute the same code path * Updated INavigationManager reference to be static readonly instead of an instance property * Aliased Constants to 'Dnn.PersonaBar.Libary.Constants' to handle ambiguity * Added DependencyInjection to website project and updated RazorHost and Export * Updated DotNetNuke.Website Globals.NavigateURL references to use the new INavigationManager * Added missing using statement * Fixing typo Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Removing whitespace Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Fix typo * Use GetRequiredService for INavigationManager Rather than waiting for a null reference later when it's used, there's never a scenario where this dependency is expected to be missing, so we want to indicate that it's expected and recieve an error right away if there's an issue * Added new DotNetNuke.Abstractions project for storing different common abstractions for the platform * Updated all (non website project) classes to use INavigationManager from the new DotNetNuke.Abstractions project * Updated Website Project to use the INavigationManager from the new DotNetNuke.Abstractions project * Removed unnecessary attributes from NavigationManager * Updated redirection controller tests to mock out the DependencyProvider and the INavigationManager to fix failing unit tests * Fixed failing unit tests with mocking out INavigationManager * Removed private fields for DependencyProvider * Added singleton clear statements to prevent the INavigationManager from remaining in memory and conflicts between unit tests * Reset singleton state for PortalController to reduce side-effects from other tests and stale object state from Dependency Injection * Moved state cleanup code to teardown routine * Fixed failing unit tests in tests.web project. Added mocks for INavigationManager so the DepenencyProvider can resolve * Added new DotNetNuke.Abstractions.nuspec to create NuGets during build * Added missing nuspec files to the solution file * Updated copyright on all nuget files * Added .NET Foundation file headers to new Abstraction files * Resolved duplicate addition of DotNetNuke.Abstractions to sln file * Added SetTestableInstance and Clear methods to make it easier to test Components. The new methods are internal * Added happy path test for Navigation Manager * Added NavigationManager tests * Updated all INavigationManager references in .ascx.cs files to use private readonly since there should never be a child class * Removed extra's added by visual studio to .csproj files
This reverts commit 697a54e. Platform/DotNetNuke.Web.Mvc/Framework/ActionResults/DnnRedirecttoRouteResult.cs Platform/DotNetNuke.Website.Deprecated/DotNetNuke.Website.Deprecated.csproj Platform/DotNetNuke.Website.Deprecated/admin/ControlPanel/AddModule.ascx.cs Platform/DotNetNuke.Website.Deprecated/admin/ControlPanel/AddPage.ascx.cs Platform/DotNetNuke.Website.Deprecated/admin/ControlPanel/ControlBar.ascx.cs Platform/DotNetNuke.Website.Deprecated/admin/ControlPanel/UpdatePage.ascx.cs Platform/DotNetNuke.Website.Deprecated/admin/ControlPanel/WebUpload.ascx.cs Platform/Modules/MemberDirectory/DotNetNuke.Modules.MemberDirectory.csproj Platform/Tests/DotNetNuke.Tests.Core/Providers/Folder/StandardFolderProviderTests.cs Platform/Tests/DotNetNuke.Tests.Core/Services/Mobile/RedirectionControllerTests.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/Extensions/CreateModuleController.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/Extensions/Dto/PackageInfoDto.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/Extensions/Editors/AuthSystemPackageEditor.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/Extensions/Editors/CoreLanguagePackageEditor.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/Extensions/Editors/ExtensionLanguagePackageEditor.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/Extensions/ExtensionsController.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/Pages/Converters.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/SiteSettings/SiteSettingsController.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/Users/Dto/UserDetailDto.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Dnn.PersonaBar.Extensions.csproj Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/MenuControllers/ExtensionMenuController.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/MenuControllers/ThemeMenuController.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Services/LanguagesController.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Services/PagesController.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Services/SeoController.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Services/ServerController.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Services/SiteSettingsController.cs Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/packages.config Dnn.AdminExperience/Library/Dnn.PersonaBar.Library/Containers/PersonaBarContainer.cs Dnn.AdminExperience/Library/Dnn.PersonaBar.Library/Dnn.PersonaBar.Library.csproj Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/MenuControllers/LinkMenuController.cs
…ment # Conflicts: # .github/ISSUE_TEMPLATE/bug-report.md # DNN Platform/Admin Modules/Dnn.Modules.Console/ViewConsole.ascx.cs # DNN Platform/Admin Modules/Dnn.Modules.ModuleCreator/CreateModule.ascx.cs # DNN Platform/Admin Modules/Dnn.Modules.ModuleCreator/viewsource.ascx.cs # DNN Platform/DotNetNuke.Web.Razor/Helpers/UrlHelper.cs # DNN Platform/DotNetNuke.Web/Mvp/ProfileModuleViewBase.cs # DNN Platform/DotNetNuke.Web/UI/WebControls/DnnRibbonBarTool.cs # DNN Platform/DotNetNuke.Website.Deprecated/admin/ControlPanel/AddModule.ascx.cs # DNN Platform/DotNetNuke.Website.Deprecated/admin/ControlPanel/AddPage.ascx.cs # DNN Platform/DotNetNuke.Website.Deprecated/admin/ControlPanel/ControlBar.ascx.cs # DNN Platform/DotNetNuke.Website.Deprecated/admin/ControlPanel/UpdatePage.ascx.cs # DNN Platform/DotNetNuke.Website.Deprecated/admin/ControlPanel/WebUpload.ascx.cs # DNN Platform/Library/Common/Globals.cs # DNN Platform/Library/Common/Internal/GlobalsImpl.cs # DNN Platform/Library/Common/Lists/ListEntryCollection.cs # DNN Platform/Library/Common/Utilities/UrlUtils.cs # DNN Platform/Library/Entities/Content/Workflow/Obsolete/ContentWorkflow.cs # DNN Platform/Library/Entities/Content/Workflow/Obsolete/ContentWorkflowController.cs # DNN Platform/Library/Entities/Content/Workflow/Obsolete/ContentWorkflowLog.cs # DNN Platform/Library/Entities/Content/Workflow/Obsolete/ContentWorkflowLogType.cs # DNN Platform/Library/Entities/Content/Workflow/Obsolete/ContentWorkflowSource.cs # DNN Platform/Library/Entities/Content/Workflow/Obsolete/ContentWorkflowState.cs # DNN Platform/Library/Entities/Content/Workflow/Obsolete/ContentWorkflowStatePermission.cs # DNN Platform/Library/Entities/Content/Workflow/Obsolete/IContentWorkflowAction.cs # DNN Platform/Library/Entities/Content/Workflow/Obsolete/IContentWorkflowController.cs # DNN Platform/Library/Entities/Modules/ISearchable.cs # DNN Platform/Library/Obsolete/CBO.cs # DNN Platform/Library/Obsolete/IModuleController.cs # DNN Platform/Library/Obsolete/IPortalAliasController.cs # DNN Platform/Library/Obsolete/IPortalSettings.cs # DNN Platform/Library/Obsolete/IRoleController.cs # DNN Platform/Library/Obsolete/ITabController.cs # DNN Platform/Library/Obsolete/IUserController.cs # DNN Platform/Library/Obsolete/LogController.cs # DNN Platform/Library/Obsolete/ModuleController.cs # DNN Platform/Library/Obsolete/PortalAliasController.cs # DNN Platform/Library/Obsolete/PortalController.cs # DNN Platform/Library/Obsolete/PortalSettings.cs # DNN Platform/Library/Obsolete/PortalTemplateIOImpl.cs # DNN Platform/Library/Obsolete/RoleController.cs # DNN Platform/Library/Obsolete/TabController.cs # DNN Platform/Library/Obsolete/TestableModuleController.cs # DNN Platform/Library/Obsolete/TestablePortalAliasController.cs # DNN Platform/Library/Obsolete/TestablePortalController.cs # DNN Platform/Library/Obsolete/TestablePortalSettings.cs # DNN Platform/Library/Obsolete/TestableRoleController.cs # DNN Platform/Library/Obsolete/TestableTabController.cs # DNN Platform/Library/Obsolete/TestableUserController.cs # DNN Platform/Library/Obsolete/UserController.cs # DNN Platform/Library/Services/Search/SearchConfig.cs # DNN Platform/Library/Services/Search/SearchCriteria.cs # DNN Platform/Library/Services/Search/SearchCriteriaCollection.cs # DNN Platform/Library/Services/Search/SearchDataStore.cs # DNN Platform/Library/Services/Search/SearchDataStoreController.cs # DNN Platform/Library/Services/Search/SearchDataStoreProvider.cs # DNN Platform/Library/Services/Search/SearchItemInfo.cs # DNN Platform/Library/Services/Search/SearchItemInfoCollection.cs # DNN Platform/Library/Services/Search/SearchResultsInfo.cs # DNN Platform/Library/Services/Search/SearchResultsInfoCollection.cs # DNN Platform/Library/UI/Modules/ProfileModuleUserControlBase.cs # DNN Platform/Modules/DigitalAssets/EditFolderMapping.ascx.cs # DNN Platform/Modules/DigitalAssets/FolderMappings.ascx.cs # DNN Platform/Modules/DigitalAssets/View.ascx.cs # DNN Platform/Modules/Groups/GroupsModuleBase.cs # DNN Platform/Modules/Groups/View.ascx.cs # DNN Platform/Modules/HTML/Components/HtmlTextController.cs # DNN Platform/Modules/HTML/EditHtml.ascx.cs # DNN Platform/Modules/HTML/HtmlModule.ascx.cs # DNN Platform/Modules/HTML/MyWork.ascx.cs # DNN Platform/Modules/RazorHost/AddScript.ascx.cs # DNN Platform/Modules/RazorHost/CreateModule.ascx.cs # DNN Platform/Modules/RazorHost/EditScript.ascx.cs # Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/Extensions/Dto/PackageInfoDto.cs # Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/Extensions/ExtensionsController.cs # Dnn.AdminExperience/Extensions/Content/Dnn.PersonaBar.Extensions/Components/Users/Dto/UserDetailDto.cs # Dnn.AdminExperience/Library/Dnn.PersonaBar.Library/Containers/PersonaBarContainer.cs # Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/MenuControllers/LinkMenuController.cs # Website/Default.aspx.cs # Website/DesktopModules/Admin/Authentication/Login.ascx.cs # Website/DesktopModules/Admin/EditExtension/AuthenticationEditor.ascx.cs # Website/DesktopModules/Admin/EditExtension/EditExtension.ascx.cs # Website/DesktopModules/Admin/Security/EditUser.ascx.cs # Website/DesktopModules/Admin/Security/ManageUsers.ascx.cs # Website/DesktopModules/Admin/Security/Membership.ascx.cs # Website/DesktopModules/Admin/Security/ProfileDefinitions.ascx.cs # Website/DesktopModules/Admin/Security/Register.ascx.cs # Website/DesktopModules/Admin/Security/SecurityRoles.ascx.cs # Website/DesktopModules/Admin/ViewProfile/ViewProfile.ascx.cs # Website/DesktopModules/AuthenticationServices/DNN/Login.ascx.cs # Website/admin/Modules/Export.ascx.cs # Website/admin/Modules/Import.ascx.cs # Website/admin/Modules/ModulePermissions.ascx.cs # Website/admin/Modules/Modulesettings.ascx.cs # Website/admin/Modules/viewsource.ascx.cs # Website/admin/Sales/Purchase.ascx.cs # Website/admin/Security/PasswordReset.ascx.cs # Website/admin/Security/SendPassword.ascx.cs # Website/admin/Skins/BreadCrumb.ascx.cs # Website/admin/Skins/LeftMenu.ascx.cs # Website/admin/Skins/Login.ascx.cs # Website/admin/Skins/Logo.ascx.cs # Website/admin/Skins/Privacy.ascx.cs # Website/admin/Skins/Search.ascx.cs # Website/admin/Skins/Terms.ascx.cs # Website/admin/Skins/User.ascx.cs # Website/admin/Skins/UserAndLogin.ascx.cs # Website/admin/Skins/tags.ascx.cs # Website/admin/Tabs/Export.ascx.cs # Website/admin/Tabs/Import.ascx.cs
Merge 9.4.x to development
JWT Audience
Update user.ascx to change order of fields for user registration (#3204)
Sitemap.aspx does not produce alternate links in multilingual website
…on set by the install manifest, instead of using the Package FriendlyName and Description, allowing multiple DesktopModules per Package. (#2887)
Resolves #3216
Improve Stale bot implementation
* Improve Stale bot messaging Resolves #3265 * Update stale.yml Additional tweak to the auto-close message to may it more non-native EN friendly.
* Do not store these portal settings when setting their property on the portalsettings object * Removed DnnHttpControllerActivator and added DependencyResolver implementation using the IServiceProvider * Added xml comments for the new DnnDependencyResolver * Added DnnDependencyResolver Unit Tests * Replaced IServiceProvider mock with full IServiceProvider implementation to work with Web API tests * Added more unit tests for the DnnDependencyResolver to cover GetServices (multiple) and BeginScope * Do not show "No Search results" message when no search is performed. (#3203) * Revision of build process part 1 (#3137) * Move website folder * repairs * Update Cake * Move external task to its own file * Begin packaging scripts in cake * Further work on packaging * Ensure Telerik project also gets new version nr * Move Telerik PDF to its proper place * New logic for packages that are already in final form in the repo and just need to be zipped. * Bring fips Lucene lib back under git control * Newtonsoft package and repair to telerik package * Splitting off other tasks * Upgrade and deploy packages * Symbols package * Get rid of platform ver in manifest * Final fixes - working packages * Move compilation stuff * House cleaning * peg utils version * Fix to ckep script * suppress warnings * Variable initialization issue * Removing unused scripts * Revert change to Telerik package version * Move "other" to "thirdparty" * Get rid of hard coded Newtonsoft version * Max cpu to 4 for compiling * Repairs to MSBuild scripts to get AE to build properly * Correcting paths * Cleaning up * Trying to fix ignore file * Update Build/Cake/thirdparty.json Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Remove absolute path from .gitignore * Fix extension of DNC library package * Merging AE and DNN build scripts * Fixes to scripts * Clean up symbols project for AE since they are included in DNN project now * Add previously untracked Yahoo compressor dlls * Remove version information from SolutionInfo.cs * Fix errors introduced in rebase * Fix incorrect paths * Change build order of MSBuild to build extensions before personabar ui. * Make white-space visible in log viewer (#3198) * DNN-34236: check the url with case insensitive. * DNN-29417 Username is changed to email address in the user profile if the "Use Email Address as Username" is enabled. * Fix to installer and the dependencies of the HTML and DA modules * DNN-24945 - Always redirect to the source portal page after creating (#3223) group * Fix Typo (#3234) * Improve querystring parse (#3242) * Improve props popup * Improve input checking of sites (#3243) * Fixes an upgrade issue that affects 9.4.1 => 9.4.2 upgrades (#3282) * Fixes an issue with a duplication of assembly binding * Removed hardcode version in manifest * Further reorganization of build process (#3236) * Introduce settings and add custom version nr * Ability to create a local dev site * Move node workspaces to root * Reshuffling of variables in MSBuild * Repairs * Fix * Allow local override of global build variables * Only save manifests if the file is not there. This prevents overwriting in case of a failed build before. * Ensure projects build in debug to the website path specified by the platform build settings * Don't track vscode folder * Fixes #3168 Test Sending Email Issues (#3237) * Use Admin Email for Send if smtpHostMode false * Fix Test Email Settings TO and FROM Addresses If I did this right and it should make sense is I set the test email to be able to go to the user testing. After all they are who are trying to make it work. It can be any email used by anyone and usually to see this feature you are a host or portal administrator so security should not be as much of a concern here. The FROM address will use the HOST email settings if set to HOST mode in DNN for the portal, otherwise it should use the Portal Administrators Email account to send from. This however does not address the issue of using the email address supplied in settings and creating another setting which will be applied next to figure out the correct logic. * Update ServerSettingsSmtpAdminController.cs * Fix build issue to previous changes. PortalSettings.UserInfo.Email is this the current user email? I am still getting my things setup. I ran VS 2019 to build successfully and I am trying to read through the namespaces correctly so I can understand the changes. I noticed a number of files possibly needing updates due to being deprecated in 9.4.2 but after I changed the namespace issue those warnings went away. One last thought is how do you get intellisense working on DNN solution. Is that a dream to have or am I missing something in my setup? * Change to address to the current user's email testing the server. I believe a UI to set the TO address would be nice to help troubleshoot and address issues trying to send to a specific user. * Corrected To address for current user email * TO Current User Email * DNN-29110 Site Assets > Select All is not working (#3251) * DNN-29110 Site Assets > Select All is not working * Code review fix * Moves Remember Login above Login Button: referenced in issue #2471 #3255 (#3256) * Move Remember Login Above Login Button * Update Login.ascx * file copy paste issue... * DNN-34250 Search is not working even after re-Indexing Search for All DNN Portals (#3260) * Fixes duplication in DotNetNuke.Website.csproj * Removed reference to missing LeftMenu files
* Fix The referenced component 'Ionic.Zip' could not be found. * Fix The referenced component 'System.Web.Http.WebHost' could not be found. * Fix The referenced component 'System.Net.Http.Formatting' could not be found. * Fix The referenced component 'System.Web.Http' could not be found. * Fix The referenced component 'PetaPoco' could not be found. * Fix DotNetNuke.Instrumentation, DotNetNuke.log4net from DotNetNuke.Test.Urls * Fix Found conflicts between different versions of "Newtonsoft.Json" that could not be resolved. These reference conflicts are listed in the build log when log verbosity is set to detailed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary