This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
[WIP] [#267] Use variables in docker-stack-compose.yml #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neongreen
commented
May 15, 2019
| export TAG=$(git rev-parse --abbrev-ref HEAD) | ||
| export SERVER_HOST=localhost | ||
| export SERVER_PORT=9000 | ||
| export SECRET_KEY="u?:IPZT:Cun;SP>edigHDs:cpUf2cY\`<7D>b9lHg98^NsVGn]:eLCIjz1Tt_VyIv" |
There was a problem hiding this comment.
TODO: how was this key generated? Add a comment.
There was a problem hiding this comment.
Run command: sbt playGenerateSecret | grep -i 'generated' | cut -d ' ' -f5 in root project directory.
neongreen
commented
May 15, 2019
| JAVA_OPTS: "-Dplay.filters.hosts.allowed.1=staging.codesearch.aelve.com -Dplay.filters.hosts.allowed.2=cloud.digitalocean.com" | ||
| # In production you must override the APPLICATION_SECRET key | ||
| APPLICATION_SECRET: ${SECRET_KEY:-"u?:IPZT:Cun;SP>edigHDs:cpUf2cY\`<7D>b9lHg98^NsVGn]:eLCIjz1Tt_VyIv"} | ||
| JAVA_OPTS: "-Dplay.filters.hosts.allowed.1=${SERVER_HOST:?}" |
There was a problem hiding this comment.
This removes the cloud.digitalocean.com host. It's unclear whether we can actually remove it without getting in trouble, though.
|
Left to do: fix .gitlab-ci.yml (I need help with that; it's unclear where |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267