Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging the error instead of throwing as exception #66

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Logging the error instead of throwing as exception #66

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c3f95f
Logging the error instead of throwing as exception
Apr 12, 2021
90b3f12
using log function
Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions aemdesign-aem-services/src/main/java/design/aem/transport/AkamaiTransportHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,15 +236,13 @@ private ReplicationResult handleRequest(ReplicationTransaction tx) throws Replic
private StringEntity createPostBody(ReplicationTransaction tx, String domain, String protocol, String additionalTrimPath, String[] excludepaths) throws ReplicationException {

JsonArray requestedJson = getPathsList(tx, domain, protocol, additionalTrimPath, excludepaths);

JsonObject json = new JsonObject();
if (requestedJson.size() > 0) {
JsonObject json = new JsonObject();
json.add("objects", requestedJson);
return new StringEntity(json.toString(), CharEncoding.ISO_8859_1);
} else {
throw new ReplicationException("No paths to purge");
currentReplicationLog.info("No paths to purge");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do same logging as rest?

}

return new StringEntity(json.toString(), CharEncoding.ISO_8859_1);
}

/**
Expand Down Expand Up @@ -286,6 +284,11 @@ private JsonArray getPathsList(ReplicationTransaction tx, String domain, String
jsonArray.add(MessageFormat.format("{0}://{1}{2}", protocol, domain, pathAfter));
}
}

// checks for empty ulr list and adds the akamai home page url.
if(jsonArray.size() == 0) {
jsonArray.add(MessageFormat.format("{0}://{1}{2}", protocol, domain, StringUtils.EMPTY));
}
}

} catch (Exception e) {
Expand Down