Integrate with new version of gotmtools & use vroom package #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'flare-no-vroom' into flare # Conflicts: # DESCRIPTION
… only used in export_config now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rewrote the main functions so that it works with a more dynamic yaml file in a recent PR for gotmtools (aemon-j/gotmtools#16). This was because when running LER in a forecasting mode, it kept crashing due to constant read/write for each time something in the yaml was changed.
Also replaced all read/write functions with the vroom package to speed up the reading and writing of files.
Dictionaries are now accessed dynamically within the package and to load them you need to use
data("met_var_dic").If no airpressure is supplied, it adds a column ~1013 Pa to the met file
Updated tests