Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Countdown in hero (1 of 4) #133

Open
BeckyMedlin opened this issue Dec 11, 2024 · 7 comments
Open

FR: Countdown in hero (1 of 4) #133

BeckyMedlin opened this issue Dec 11, 2024 · 7 comments
Assignees
Labels
Milestone

Comments

@BeckyMedlin
Copy link
Collaborator

BeckyMedlin commented Dec 11, 2024

User Story

As a long-haul customer interested in buying a new truck, I want to sign up to receive updates so that I can be kept up-to-date about M1.

Context/Description

MT teaser for M1 needs to include a hero countdown clock during the pre-reveal phase.
Leverage existing code from previous VNL launch. Netcentric/vg-volvotrucks-us-rd#66

Add the countdown in the section metadata for the hero (with the time and the date) and only load the countdown block when this date or time metadata is on the page.

###Assumptions:
When the countdown runs out then all the values would be 00.

If the user is visiting the page while the event is being live or have been expired then the countdown will not be displayed.

The date format should be in ISO 8601 format. E.g '2023-11-20T14:00:00.000Z'. Editors can add this date in the section meta data. Default time zone should be EST.

Countdown should start from April 8, 2025.

See design: https://www.figma.com/design/apGFsQv4eiZuJ9N6DxCFIm/M1-Teaser-landing-page?node-id=0-1&t=tmh2YYAhwPJpN9lX-1
Figma includes both Desktop and Mobile designs.

Acceptance Criteria

User AC:

  • The countdown will be shown below the title in the hero

  • All digits need to be shown on the same line

  • The digits need to be using font-feature-settings: 'tnum'; to maintain alignment

  • Granularity will be days/hours/minutes/seconds

  • All numbers will have two digits. When needed, use a leading zero. For example: "04" or "20"

  • A date should be set by a content editor.

  • Editors should be able to left-justify text.

  • Colors and Mack Trucks branding guidelines need to be followed.

  • A new "bold" font should be included.

Work for form will be handled in #145 (see Out of Scope).

Editor AC:

Non-functional AC:

Out of scope

Technical details

No response

Attachment / link to Figma

No response

@BeckyMedlin BeckyMedlin added the M1 label Dec 11, 2024
@BeckyMedlin BeckyMedlin added this to the M1 Launch milestone Dec 11, 2024
@mollyaljenkins
Copy link

Finalized design in Figma needed with day:hour:minute:second format @WendyKruger

@Meli-lazarte
Copy link
Collaborator

A separate tickt will be created for the form section.

@BeckyMedlin
Copy link
Collaborator Author

@ryanropero @WendyKruger Need details for the MCAE form needed for the countdown page, which will be handled in a separate ticket.

@mollyaljenkins mollyaljenkins changed the title FR: Countdown in hero FR: Countdown in hero (1 of 2) Dec 17, 2024
@BeckyMedlin
Copy link
Collaborator Author

BeckyMedlin commented Jan 7, 2025

Per @WendyKruger, decision on what to display once the countdown reaches 00:00:00:00 is still to be determined. This will need to be addressed in a separate ticket. @Meli-lazarte

@Meli-lazarte Meli-lazarte changed the title FR: Countdown in hero (1 of 2) FR: Countdown in hero (1 of 3) Jan 8, 2025
@alan-le-bihan
Copy link
Collaborator

alan-le-bihan commented Jan 16, 2025

Question and comments about some of the AC:

  • A new 'bold' font should be included: could clarification be provided on which font is being referred to and which text it should be applied to? The font available in Figma for the digits has been included. Does this address the AC?
  • Editors should be able to left-justify text: this is already the default behaviour when adding text.

@BeckyMedlin
Copy link
Collaborator Author

@amglebihan Yes, the font in the Figma addresses the AC. Regarding the other items, that's fine. Thank you!

@AsmitKMishra AsmitKMishra self-assigned this Jan 20, 2025
@Meli-lazarte Meli-lazarte changed the title FR: Countdown in hero (1 of 3) FR: Countdown in hero (1 of 4) Jan 20, 2025
@AsmitKMishra
Copy link
Collaborator

AsmitKMishra commented Jan 21, 2025

Testing Completed. Feature works as expected. And fulfils the acceptance criteria.
Mobile:

Image

Desktop:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants