Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: specify correct dns address #147

Merged
merged 1 commit into from
May 22, 2024
Merged

kubernetes: specify correct dns address #147

merged 1 commit into from
May 22, 2024

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented May 21, 2024 •
edited
Loading

Kamaji specifies coredns address 10.96.0.10 by default, since we're using 10.95.0.0/16 service networking we have to specify correct dns address 10.95.0.10

reported by @kingdonb

upstream issue clastix/kamaji#468

@kvaps kvaps changed the title fix dns kubernetes: specify correct dns address May 21, 2024
@kvaps kvaps mentioned this pull request May 21, 2024
Open
@gecube
Copy link
Collaborator

gecube commented May 22, 2024

I'd prefer to use addresses from RFC 6598. From the 100.64.0.0/10 range.
Like 100.64.0.0/16 for the pods and 100.65.0.0/16 for the services. If we are using overlay - then we can reuse the same settings for all the clusters. But probably it would be wise to allocate to every next cluster another block. Like control cluster - 100.64.0.0/16 and 100.65.0.0/16, then first tenant cluster - 100.66.0.0/16 and 100.67.0.0/16, second tenant cluster - 100.68.0.0/16 and 100.69.0.0/16 and etc.

@gecube
Copy link
Collaborator

gecube commented May 22, 2024

and also better to not to hardcode this value and to put it like defaults on values.yaml level of the chart.

@kvaps
Copy link
Member Author

kvaps commented May 22, 2024

first tenant cluster - 100.66.0.0/16 and 100.67.0.0/16, second tenant cluster - 100.68.0.0/16 and 100.69.0.0/16 and etc.

For now this makes no sense, because currently the tenant clusters can't reach services over each other.

To make this working we have to enable the routing between them.

@gecube
Copy link
Collaborator

gecube commented May 22, 2024

agree, just mentioned it here not to forget later.

@kvaps kvaps merged commit 5f01f30 into main May 22, 2024
themoriarti added a commit that referenced this pull request May 23, 2024
@themoriarti @kvaps
Sync main to integration (#146)
df168e8 
* upd kubernetes (#134)

* Allow root login without password

* add ephemeral volumes for containerd and kubelet

* update kubernetes application

* etcd: Add quota-backend-bytes calculations (#133)

* Prepare release v0.6.0 (#135)

* etcd: enable autocompact and defrag (#137)

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

* switched place -maxdepth im Makefiles (#140)

* postgres: fix users and roles (#138)

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

* kubernetes: enable bpf masqurade and tunnel routing (#144)

* Unhardcode cluster.local domain (#142)

Allow using other domains for the cluster

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

* kamaji: unhardcode cluster.local domain (#145)

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

* kubernetes: specify correct dns address (#147)

---------

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Co-authored-by: Andrei Kvapil <kvapss@gmail.com>
This was referenced May 24, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jun 10, 2024
Merged
Merged
Merged
Merged
This was referenced Jun 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gecube gecube gecube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvaps @gecube