-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kafka): add exporter #408
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: George Gaál <gb12335@gmail.com>
WalkthroughThe pull request includes updates to two files related to the Kafka application. The Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I add resource request and limiting for kafka exporter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix conflicts
Add kafka exporter:
https://strimzi.io/blog/2019/10/14/improving-prometheus-metrics/
https://strimzi.io/docs/0.14.0/full#assembly-kafka-exporter-configuration-deployment-configuration-kafka
Summary by CodeRabbit
kafkaExporter
section in the Kafka resource configuration, allowing for flexible matching of consumer groups and topics using regular expressions.kafkaExporter
configuration.These enhancements improve the configuration capabilities for users managing Kafka resources.