fix: grafana ingress class #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecube
requested changes
Apr 17, 2024
| @@ -68,6 +68,7 @@ spec: | |||
| metadata: | |||
| annotations: | |||
| kubernetes.io/ingress.class: "{{ $ingress }}" | |||
| acme.cert-manager.io/http01-ingress-class: "{{ $ingress }}" | |||
There was a problem hiding this comment.
I was sure that the ingress class would be taken from ingressClassName field. Are you sure that it is necessary?
There was a problem hiding this comment.
Yeah, I also tried to omit ingressClass from cluster issuer, unfortunately it didn't work.
There was a problem hiding this comment.
ingressClass from cluster issuer, unfortunately it didn't work.
it should be only in Cluster Issuer, right?
There was a problem hiding this comment.
Dunno, when cluster issure missing the section
solvers:
- http01:
ingress:
class: nginxcert-manager reports an error:
Failed to determine a valid solver configuration for the set of domains on the Order: no configured challenge solvers can be used for this challenge
even with this annotation
| @@ -68,6 +68,7 @@ spec: | |||
| metadata: | |||
| annotations: | |||
| kubernetes.io/ingress.class: "{{ $ingress }}" | |||
There was a problem hiding this comment.
you could bravely remove it - it is obsolete
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps
force-pushed
the
grafana-ingress-class
branch
from
773befa to
8fcaed4
Compare
gecube
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grafana uses default ingress class
nginxspecified in ClusterIssuer resource, we need to overwrite it to correct ingress class from namespace annotation