[ENH] make single problem loaders for equal length problems return numpy arrays #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickzib
previously requested changes
Feb 25, 2023
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
its in the cards, I think I will change the name to load_tsc_problem, but it needs to also load unequal problems so was going to delay until we remove DataFrames all together
see my other comments |
patrickzib
dismissed
their stale review
Issues with 2d numpy and transformers should be moved to different PR
|
I had no idea that the single problem loaders were used so much in testing (other than correctness testing), this is surely not a good idea, will raise an issue |
|
well, that tweak to kill time on a saturday morning became a monster! |
|
I would give you a badge of honour! :) |
patrickzib
reviewed
Feb 28, 2023
|
thanks for the review @patrickzib , think I have addressed all issues now |
patrickzib
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the return_type from None to numpy3d and remove the very long comments describing possible data structures in unnecessary detail. Part of #42
edit: sorry this touches so many files, I had no idea that the single problem loaders were used so much in testing (other than correctness testing). I think unless testing actual output, tests should use randomly generated data from tests/_testing package. I've had a look through a fair few tests on this epic trawl, and there seems to be a lot of testing for testing sake in obscure code such as benchmarking. There is testing same thing on very similar datasets, using larger datasets unnecessarily etc. I have raised an issue #118