Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Update landing page #122

Merged
merged 26 commits into from
Mar 15, 2023
Merged

[DOC] Update landing page #122

merged 26 commits into from
Mar 15, 2023

Conversation

MatthewMiddlehurst
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst commented Feb 27, 2023 •
edited
Loading

  • Updates the landing page using the furo sphinx theme.
  • Adds some placeholder logos.
  • replaces the previous introduction, mission statement and content with panels linking to each module and links to social media.
  • replaces the reStructuredTex .rst file with the more common Markdown .md

@MatthewMiddlehurst MatthewMiddlehurst added the documentation Improvements or additions to documentation label Feb 27, 2023
@MatthewMiddlehurst
conf.py update
08bc36e
@MatthewMiddlehurst
clean index
0c55a6b
@MatthewMiddlehurst
toc move around
1e4b8ba
@MatthewMiddlehurst
images
0635ed5
@MatthewMiddlehurst
fix and community
73c6c9c
@MatthewMiddlehurst
furo
32230a7
@MatthewMiddlehurst
furo2
92b5e95
@MatthewMiddlehurst
temp logo
4ade0f7
@MatthewMiddlehurst
annoying
de24e2e
@MatthewMiddlehurst
Merge branch 'main' of https://github.com/scikit-time/scikit-time int…
dd118f8 
…o confpy

# Conflicts:
#	docs/source/conf.py
@MatthewMiddlehurst
markdown index
36b61e3
@MatthewMiddlehurst
Merge branch 'main' of https://github.com/scikit-time/scikit-time int…
e3da923 
…o confpy

# Conflicts:
#	docs/source/about/artwork.rst
#	docs/source/conf.py
#	docs/source/images/aeon-favicon.ico
#	docs/source/images/aeon-logo-no-text-vertical.png
#	docs/source/images/aeon-logo-no-text.jpg
#	docs/source/images/aeon-logo-text-horizontal.png
#	docs/source/images/aeon-logo.jpg
#	docs/source/index.rst
@MatthewMiddlehurst
more options
7aa1f11
@MatthewMiddlehurst
fix
b7c777f
@MatthewMiddlehurst
index markdown fixes
fda9c84
@MatthewMiddlehurst
images and secondary colour change
3d9ce0c
@MatthewMiddlehurst
aeon title color and links
f4db03c
@MatthewMiddlehurst
break
b8cf5ea
@MatthewMiddlehurst MatthewMiddlehurst mentioned this pull request Mar 7, 2023
Closed
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review March 7, 2023 15:48
TonyBagnall
TonyBagnall previously approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant really tell what it looks like, but good to progress so others can comment

@MatthewMiddlehurst
Copy link
Member Author

You can see by pressing details on the docs test. Don't think we should merge yet as it breaks at least one other page and would be good to get comments.

image

GuzalBulatova
GuzalBulatova previously approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@GuzalBulatova GuzalBulatova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is so good! I think the images for the ml tasks are great addition: they're informative, and make the landing page look way easier on the eye. One thing I'd change is make the red colour a bit more muted, what do you think? Of course this can be done further and isn't a blocker.
What is failing (you mentioned in the previous comment) @MatthewMiddlehurst ? All looks fine on my side.

@MatthewMiddlehurst
Copy link
Member Author

Currently, the Installation page fails due to the style change. I agree the fonts and colour contrast should be worked on. I think I changed them on my fork to be a bit better, will try to pull it over to this PR when the package rename has settled.

@MatthewMiddlehurst
Copy link
Member Author

Maybe there is no rush to change every page immediately though, I can have a look through and change the obvious things in another PR.

@lmmentel lmmentel dismissed stale reviews from GuzalBulatova and TonyBagnall via 58c7c88 March 12, 2023 14:00
@lmmentel
Copy link
Contributor

Looks great, let's merge this and start improving from there!

lmmentel
lmmentel previously approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@lmmentel lmmentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lmmentel lmmentel added this to the initial release milestone Mar 12, 2023
@MatthewMiddlehurst
Copy link
Member Author

No one seems to be against this, and we can change as we go. Of course, feel free to recommend updates whenever.

@MatthewMiddlehurst MatthewMiddlehurst merged commit d0c06dd into main Mar 15, 2023
@MatthewMiddlehurst MatthewMiddlehurst deleted the confpy branch March 15, 2023 21:51
@MatthewMiddlehurst MatthewMiddlehurst removed this from the v0.2.0 milestone Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmmentel lmmentel lmmentel approved these changes

@TonyBagnall TonyBagnall TonyBagnall left review comments

@GuzalBulatova GuzalBulatova GuzalBulatova left review comments

@aiwalter aiwalter Awaiting requested review from aiwalter

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatthewMiddlehurst @lmmentel @TonyBagnall @GuzalBulatova