[BUG] Update check_n_jobs #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickzib
requested changes
Feb 4, 2023
|
If negative I'd probably just return 1? |
|
Ah does -x generally mean use this number fewer than max as a convention, as in it's not a misuse? |
GuzalBulatova
approved these changes
Feb 5, 2023
|
Waiting on CI. better safe than sorry. |
aiwalter
added a commit
that referenced
this pull request
Feb 15, 2023
* [GOV] Revert CoC to remove FK changes (#17) * Revert CoC to remove FK changes * Removed FK name from COC * Removed FK name from COC * Removed NumFOCUS as second CoCC * Remove NumFOCUS * Removed NumFOCUS * Removed NumFOCUS * [GOV] Removed 7 days discussion period before votings. Removed weekend rule by adding 2 days instead (#41) * Removed 7 days discussion time for CC and CoC votes * Removed 7 days discussion time for CC and CoC votes * Removed 7 days discussion time for CC and CoC votes * Removed 7 days discussion time for CC and CoC votes * Removed 7 days discussion time for CC and CoC votes * Removed 7 days discussion time for CC and CoC votes * Removed 7 days discussion time for CC and CoC votes * Removed 21 days and chanfed back to 14 days * [GOV] CC and CoC term limitation to 2 years (#22) * [FORK] Update README (IN PROGRESS) (#43) * simple readme name replace * manual changes * disclaimer * readme split * [GOV] Updated team page (#19) * Updated team page * previous devs * missed one --------- Co-authored-by: Matthew Middlehurst <m.middlehurst@uea.ac.uk> * [FORK] Revert #15 "Remove workflow files" (MERGE WHEN REPO PUBLIC) (#16) * temporarily stop this action * comment out all github workflows * revert * remove workflows * add workflows * uncommented * license update (#56) * [BUG] Update check_n_jobs (#14) * check_n_jobs * check_n_jobs * min 1 thread * Added CoCC members (#57) * [ENH] Dictionary Classifiers (#58) Maintenance of Dictionary Classifiers - Reverts alphabet_size=4 for BOSS and WEASEL, - carries out deprecation of cBOSS - adds dilation to SFAFast - Tidies up Doc-Strings * remove shellcheck (#60) * add disclaimer (#64) --------- Co-authored-by: Matthew Middlehurst <pfm15hbu@uea.ac.uk> Co-authored-by: Matthew Middlehurst <m.middlehurst@uea.ac.uk> Co-authored-by: Patrick Schäfer <patrick.schaefer@hu-berlin.de> Co-authored-by: Lukasz Mentel <lmmentel@users.noreply.github.com>
aadya940
added a commit
to aadya940/aeon
that referenced
this pull request
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
check_n_jobsdocs. Fixes output for negative n_jobs. 0 input return 1.Location of the functions seems a bit weird, but left it for now.