Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Refactor ColumnEnsemble to ChannelEnsemble #162

Merged
merged 15 commits into from
Mar 8, 2023

Conversation

TonyBagnall
Copy link
Contributor

@TonyBagnall TonyBagnall commented Mar 7, 2023

This refactors the classifier ColumEnsembleClassifier to becomre ChannelEnsembleClassifier based on discussion on #121

Other changes

  1. Internal names changed from column to channel
  2. Base class BaseChannelEnsembleClassifier made private
  3. Internal input type changed to numpy3D (see [ENH] removing the use of nested_univ/nested np.DataFrames in time series machine learning #110)
  4. Removes the ability to give channel names

this could now be significantly simplified and tidied up. I see no real need for a base class and a lot of the checks relate only to "nested_univ" Pandas datatype. I think all that can be part of the introduction of lists of numpy for unequal length.

Reference Issues/PRs

Fixes #121
partially addresses #110

Please use keywords (e.g., Fixes) to create link to the issues or pull requests
you resolved, so that they will automatically be closed when your pull request
is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests
-->

@TonyBagnall TonyBagnall added the classification Classification package label Mar 7, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@TonyBagnall TonyBagnall marked this pull request as ready for review March 7, 2023 09:10
@MatthewMiddlehurst MatthewMiddlehurst changed the title [enh] Refactor ColumnEnsemble to ChannelEnsemble [ENH] Refactor ColumnEnsemble to ChannelEnsemble Mar 7, 2023
Copy link
Contributor

@patrickzib patrickzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@TonyBagnall TonyBagnall requested a review from patrickzib March 7, 2023 12:42
Copy link
Contributor

@patrickzib patrickzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@TonyBagnall TonyBagnall merged commit 67d037b into main Mar 8, 2023
@TonyBagnall TonyBagnall deleted the ajb/column_ensemble branch March 8, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Terminology for multivariate classification problems: columns, dimensions or channels?
2 participants